Merge branch 'bug/ping-data' into 'dev'

Check if ping result is boolean

See merge request crafty-controller/crafty-4!371

CHANGELOG.md

@@ -6,6 +6,7 @@
 - Add shutdown on backup feature ([Merge Request](https://gitlab.com/crafty-controller/crafty-4/-/merge_requests/373))
 ### Bug fixes
 - Backup/Config.json rework for API key hardening ([Merge Request](https://gitlab.com/crafty-controller/crafty-4/-/merge_requests/369))
+- Fix stack on ping result being falsy ([Merge Request](https://gitlab.com/crafty-controller/crafty-4/-/merge_requests/371))
 ### Tweaks
 - Spelling mistake fixed in German lang file ([Merge Request](https://gitlab.com/crafty-controller/crafty-4/-/merge_requests/370))
 - Backup failure warning (Tab text goes red) ([Merge Request](https://gitlab.com/crafty-controller/crafty-4/-/merge_requests/373))

app/classes/minecraft/stats.py

@@ -265,15 +265,24 @@ class Stats:
             logger.info(
                 "Unable to read the server icon due to the following error:", exc_info=e
             )
-
-        ping_data = {
-            "online": online_stats.get("online", 0),
-            "max": online_stats.get("max", 0),
-            "players": online_stats.get("players", 0),
-            "server_description": ping_obj.description,
-            "server_version": ping_obj.version,
-            "server_icon": server_icon,
-        }
+        if ping_obj:
+            ping_data = {
+                "online": online_stats.get("online", 0),
+                "max": online_stats.get("max", 0),
+                "players": online_stats.get("players", 0),
+                "server_description": ping_obj.description,
+                "server_version": ping_obj.version,
+                "server_icon": server_icon,
+            }
+        else:
+            ping_data = {
+                "online": online_stats.get("online", 0),
+                "max": online_stats.get("max", 0),
+                "players": online_stats.get("players", 0),
+                "server_description": "",
+                "server_version": "",
+                "server_icon": server_icon,
+            }
 
         return ping_data