From 6f80b3e5c1f0f19172d8203e7e5c1ef610f63e6b Mon Sep 17 00:00:00 2001 From: amcmanu3 Date: Tue, 5 Jul 2022 15:24:19 -0400 Subject: [PATCH 1/2] Fix bug with bool obj on server start --- app/classes/minecraft/stats.py | 26 ++++++++++++++++++-------- 1 file changed, 18 insertions(+), 8 deletions(-) diff --git a/app/classes/minecraft/stats.py b/app/classes/minecraft/stats.py index 3cc52f88..64cbf894 100644 --- a/app/classes/minecraft/stats.py +++ b/app/classes/minecraft/stats.py @@ -266,14 +266,24 @@ class Stats: "Unable to read the server icon due to the following error:", exc_info=e ) if ping_obj: - ping_data = { - "online": online_stats.get("online", 0), - "max": online_stats.get("max", 0), - "players": online_stats.get("players", 0), - "server_description": ping_obj.description, - "server_version": ping_obj.version, - "server_icon": server_icon, - } + try: + ping_data = { + "online": online_stats.get("online", 0), + "max": online_stats.get("max", 0), + "players": online_stats.get("players", 0), + "server_description": ping_obj.description, + "server_version": ping_obj.version, + "server_icon": server_icon, + } + except: + ping_data = { + "online": online_stats.get("online", 0), + "max": online_stats.get("max", 0), + "players": online_stats.get("players", 0), + "server_description": "", + "server_version": "", + "server_icon": server_icon, + } else: ping_data = { "online": online_stats.get("online", 0), From 66f637484bfa490fb034385f09a266ada3ab63b7 Mon Sep 17 00:00:00 2001 From: Zedifus Date: Tue, 5 Jul 2022 23:30:22 +0100 Subject: [PATCH 2/2] Update changelog !391 --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 16dd566f..a211def5 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,7 @@ None ### Bug fixes - Remove redundant path check on backup restore ([Merge Request](https://gitlab.com/crafty-controller/crafty-4/-/merge_requests/390)) +- Fix issue with stats pinging on slow starting servers ([Merge Request](https://gitlab.com/crafty-controller/crafty-4/-/merge_requests/391)) ### Tweaks None ### Lang