Merge branch 'bug/backup-config-persistance' into 'dev'

Clean up backup configs when deleting servers

See merge request crafty-controller/crafty-4!480

CHANGELOG.md

@@ -6,6 +6,7 @@ TBD
 - Fix conditional issue with zip imports/uploads ([Merge Request](https://gitlab.com/crafty-controller/crafty-4/-/merge_requests/476))
 - Fix API Schedule updates ([Merge Request](https://gitlab.com/crafty-controller/crafty-4/-/merge_requests/478))
 - Add port constraint for all server creation & api ([Merge Request](https://gitlab.com/crafty-controller/crafty-4/-/merge_requests/479))
+- Clean up backup configs when deleting servers ([Merge Request](https://gitlab.com/crafty-controller/crafty-4/-/merge_requests/480))
 ### Tweaks
 - Fix sidebar to not move when scrolling ([Merge Request](https://gitlab.com/crafty-controller/crafty-4/-/merge_requests/475))
 ### Lang

app/classes/controllers/servers_controller.py

@@ -134,8 +134,13 @@ class ServersController(metaclass=Singleton):
             role_id = role.role_id
             role_data = RolesController.get_role_with_servers(role_id)
             role_data["servers"] = {server_id}
+            # Remove server id permissions from role
             PermissionsServers.delete_roles_permissions(role_id, role_data["servers"])
+        # Remove roles from server
         PermissionsServers.remove_roles_of_server(server_id)
+        # Remove backup configs tied to server
+        self.management_helper.remove_backup_config(server_id)
+        # Finally remove server
         self.servers_helper.remove_server(server_id)
 
     @staticmethod

app/classes/models/management.py

@@ -367,6 +367,10 @@ class HelpersManagement:
             }
         return conf
 
+    @staticmethod
+    def remove_backup_config(server_id):
+        Backups.delete().where(Backups.server_id == server_id).execute()
+
     def set_backup_config(
         self,
         server_id: int,