From 912785b28014f7817b584eea606e517bb42f4aa7 Mon Sep 17 00:00:00 2001 From: amcmanu3 Date: Thu, 21 Mar 2024 18:10:39 -0400 Subject: [PATCH 1/4] Remove http references from codebase --- app/classes/web/routes/api/crafty/config/index.py | 1 - app/classes/web/tornado_handler.py | 6 +----- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/app/classes/web/routes/api/crafty/config/index.py b/app/classes/web/routes/api/crafty/config/index.py index c901732c..4a9cbd63 100644 --- a/app/classes/web/routes/api/crafty/config/index.py +++ b/app/classes/web/routes/api/crafty/config/index.py @@ -9,7 +9,6 @@ from app.classes.web.base_api_handler import BaseApiHandler config_json_schema = { "type": "object", "properties": { - "http_port": {"type": "integer"}, "https_port": {"type": "integer"}, "language": { "type": "string", diff --git a/app/classes/web/tornado_handler.py b/app/classes/web/tornado_handler.py index f65f4fca..6285edfc 100644 --- a/app/classes/web/tornado_handler.py +++ b/app/classes/web/tornado_handler.py @@ -98,7 +98,6 @@ class Webserver: # let's verify we have an SSL cert self.helper.create_self_signed_cert() - http_port = self.helper.get_setting("http_port") https_port = self.helper.get_setting("https_port") debug_errors = self.helper.get_setting("show_errors") @@ -110,9 +109,6 @@ class Webserver: cookie_secret = self.helper.random_string_generator(32) HelpersManagement.set_cookie_secret(cookie_secret) - if not http_port and http_port != 0: - http_port = 8000 - if not https_port: https_port = 8443 @@ -125,7 +121,7 @@ class Webserver: ), } - logger.info(f"Starting Web Server on ports http:{http_port} https:{https_port}") + logger.info(f"Starting Web Server on ports https:{https_port}") asyncio.set_event_loop(asyncio.new_event_loop()) From 4a134278aeb725bcdb98fe60f2109b96a4602789 Mon Sep 17 00:00:00 2001 From: Dylan Oonk Date: Sun, 24 Mar 2024 22:49:47 +0000 Subject: [PATCH 2/4] remove version disclosure from login --- app/frontend/templates/public/login.html | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/app/frontend/templates/public/login.html b/app/frontend/templates/public/login.html index 5a54ecca..275d2000 100644 --- a/app/frontend/templates/public/login.html +++ b/app/frontend/templates/public/login.html @@ -111,8 +111,7 @@
From e564208140bc8881a722d59219f83d4404dcd9a1 Mon Sep 17 00:00:00 2001 From: Zedifus Date: Tue, 2 Apr 2024 23:56:05 +0100 Subject: [PATCH 3/4] Update changelog !733 --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 44750a39..c3b07600 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,7 +5,7 @@ TBD ### Bug fixes TBD ### Tweaks -TBD +- Clean up remaining http handler references ([Merge Request](https://gitlab.com/crafty-controller/crafty-4/-/merge_requests/733)) ### Lang TBD

From 655546446501b1af6521e7253d9b133b5b6395c4 Mon Sep 17 00:00:00 2001 From: Zedifus Date: Wed, 3 Apr 2024 00:24:54 +0100 Subject: [PATCH 4/4] Update changelog !737 --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index c3b07600..9c879e67 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,6 +6,7 @@ TBD TBD ### Tweaks - Clean up remaining http handler references ([Merge Request](https://gitlab.com/crafty-controller/crafty-4/-/merge_requests/733)) +- Remove version disclosure on login page ([Merge Request](https://gitlab.com/crafty-controller/crafty-4/-/merge_requests/737)) ### Lang TBD