From 65ba65a67db5819e3b4e250f0c024438e66476ce Mon Sep 17 00:00:00 2001 From: luukas Date: Mon, 16 May 2022 01:12:03 +0300 Subject: [PATCH] Make model *_exists functions way more efficient --- app/classes/models/roles.py | 4 +--- app/classes/models/servers.py | 4 +--- app/classes/models/users.py | 4 +--- 3 files changed, 3 insertions(+), 9 deletions(-) diff --git a/app/classes/models/roles.py b/app/classes/models/roles.py index 373fa11d..009aceb5 100644 --- a/app/classes/models/roles.py +++ b/app/classes/models/roles.py @@ -70,6 +70,4 @@ class HelperRoles: @staticmethod def role_id_exists(role_id): - if not HelperRoles.get_role(role_id): - return False - return True + return Roles.select().where(Roles.role_id == role_id).count() != 0 diff --git a/app/classes/models/servers.py b/app/classes/models/servers.py index aa6744c0..8527b52e 100644 --- a/app/classes/models/servers.py +++ b/app/classes/models/servers.py @@ -205,9 +205,7 @@ class HelperServers: @staticmethod def server_id_exists(server_id): - if not HelperServers.get_server_data_by_id(server_id): - return False - return True + return Servers.select().where(Servers.server_id == server_id).count() != 0 @staticmethod def sever_crashed(server_id): diff --git a/app/classes/models/users.py b/app/classes/models/users.py index d2778646..59a9169e 100644 --- a/app/classes/models/users.py +++ b/app/classes/models/users.py @@ -249,9 +249,7 @@ class HelperUsers: @staticmethod def user_id_exists(user_id): - if not HelperUsers.get_user(user_id): - return False - return True + return Users.select().where(Users.user_id == user_id).count() != 0 # ********************************************************************************** # User_Roles Methods