From df868971086a571e34f2501780af3d561c2b2f60 Mon Sep 17 00:00:00 2001 From: Zedifus Date: Fri, 3 Jun 2022 18:33:21 +0100 Subject: [PATCH] Change for to forEach loop > Fixes ESLint rule ID security/detect-object-injection --- app/frontend/templates/panel/dashboard.html | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/app/frontend/templates/panel/dashboard.html b/app/frontend/templates/panel/dashboard.html index c51c35f0..593e717c 100644 --- a/app/frontend/templates/panel/dashboard.html +++ b/app/frontend/templates/panel/dashboard.html @@ -593,14 +593,16 @@ let servers = document.getElementsByClassName("server-player-totals"); let all_total_players = 0; let all_total_max_players = 0; - for (let i = 0; i < servers.length; i++) { + + servers.forEach(server => { try { - all_total_players += parseInt(servers[i].getAttribute('data-players')); - all_total_max_players += parseInt(servers[i].getAttribute('data-max')); + all_total_players += server.getAttribute('data-players'); + all_total_max_players += servers.getAttribute('data-max'); } catch { console.log("Player totals are not of type int"); } - } + }) + total_players.innerHTML = all_total_players; document.getElementById('max_players').innerHTML = all_total_max_players; document.getElementById('sync').innerHTML = '';