From 0f14b123efd11e0e3bddd5259ffd6ffca96e5ca6 Mon Sep 17 00:00:00 2001 From: mag37 Date: Wed, 18 Jan 2023 19:24:29 +0100 Subject: [PATCH] Update dockcheck_function.sh safer code, encapsulation etc --- dockcheck_function.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/dockcheck_function.sh b/dockcheck_function.sh index 14ea661..2ebfaa0 100644 --- a/dockcheck_function.sh +++ b/dockcheck_function.sh @@ -9,9 +9,9 @@ dockcheck () { echo "No container name given, here's the list of currently running containers:" docker ps --format '{{.Names}}' else - RepoUrl=$(docker inspect $1 --format='{{.Config.Image}}') - LocalHash=$(docker image inspect $RepoUrl --format '{{.RepoDigests}}' | sed -e 's/.*sha256/sha256/' -e 's/\]$//') - RegHash=$(regctl image digest --list $RepoUrl) + RepoUrl=$(docker inspect "$1" --format='{{.Config.Image}}') + LocalHash=$(docker image inspect "$RepoUrl" --format '{{.RepoDigests}}' | sed -e 's/.*sha256/sha256/' -e 's/\]$//') + RegHash=$(regctl image digest --list "$RepoUrl") if [[ "$LocalHash" != "$RegHash" ]] ; then printf "Updates available.\n" ; else printf "Already latest.\n" ; fi fi }