From be87c45f276f4ed515035134c3bc2ac20e3b1692 Mon Sep 17 00:00:00 2001
From: Rahul Somasundaram <ssrahul96@gmail.com>
Date: Tue, 24 Aug 2021 06:01:08 +0530
Subject: [PATCH] thrown exception for non LE certificates

---
 backend/internal/certificate.js          | 46 ++++++++++++++++--------
 backend/routes/api/nginx/certificates.js |  2 +-
 2 files changed, 32 insertions(+), 16 deletions(-)

diff --git a/backend/internal/certificate.js b/backend/internal/certificate.js
index 413091a0..1e7a1086 100644
--- a/backend/internal/certificate.js
+++ b/backend/internal/certificate.js
@@ -337,29 +337,45 @@ const internalCertificate = {
 	},
 
 	/**
+	 * @param   {Access}  access
 	 * @param   {Object}  data
 	 * @param   {Number}  data.id
 	 * @returns {Promise}
 	 */
-	download: (data) => {
-		const downloadName = 'npm-' + data.id + '-' + `${Date.now()}.zip`;
-		const opName       = '/tmp/' + downloadName;
-		const zipDirectory = '/etc/letsencrypt/live/npm-' + data.id;
-	
+	download: (access, data) => {
+
 		return new Promise((resolve, reject) => {
-			internalCertificate.zipDirectory(zipDirectory, opName)
+			access.can('certificates:get', data)
 				.then(() => {
-					logger.debug('zip completed : ', opName);
-					const resp = {
-						fileName: opName
-					};
-					resolve(resp);
-				}).catch((err) => {
-					reject(err);
-				});
+					return internalCertificate.get(access, data);
+				})
+				.then((certificate) => {
+					if (certificate.provider === 'letsencrypt') {
+						const zipDirectory = '/etc/letsencrypt/live/npm-' + data.id;
+
+						if (!fs.existsSync(zipDirectory)) {
+							throw new error.ItemNotFoundError('Certificate ' + certificate.nice_name + ' does not exists');
+						}
+
+						const downloadName = 'npm-' + data.id + '-' + `${Date.now()}.zip`;
+						const opName       = '/tmp/' + downloadName;
+						internalCertificate.zipDirectory(zipDirectory, opName)
+							.then(() => {
+								logger.debug('zip completed : ', opName);
+								const resp = {
+									fileName: opName
+								};
+								resolve(resp);
+							}).catch((err) => {
+								reject(err);
+							});
+					} else {
+						throw new error.ValidationError('Only Let\'sEncrypt certificates can be renewed');
+					}
+				}).catch((err) => reject(err));
 		});
 	},
-	
+
 	/**
 		 * @param {String} source
 		 * @param {String} out
diff --git a/backend/routes/api/nginx/certificates.js b/backend/routes/api/nginx/certificates.js
index f209bf6a..32995c53 100644
--- a/backend/routes/api/nginx/certificates.js
+++ b/backend/routes/api/nginx/certificates.js
@@ -228,7 +228,7 @@ router
 	 * Renew certificate
 	 */
 	.get((req, res, next) => {
-		internalCertificate.download({
+		internalCertificate.download(res.locals.access, {
 			id: parseInt(req.params.certificate_id, 10)
 		})
 			.then((result) => {