From 0be9174bb1d7d383af4fa058b2a28ebe525a1f25 Mon Sep 17 00:00:00 2001 From: tt2468 Date: Wed, 28 Apr 2021 12:36:15 -0700 Subject: [PATCH] WebSocketServer: Don't call stop() on the server For some reason I thought I was supposed to call it /shrug --- src/WebSocketServer.cpp | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/WebSocketServer.cpp b/src/WebSocketServer.cpp index 864492b1..8627dbeb 100644 --- a/src/WebSocketServer.cpp +++ b/src/WebSocketServer.cpp @@ -122,13 +122,11 @@ void WebSocketServer::Stop() _threadPool.waitForDone(); - // This can deadlock the thread that it is running on. Bad but kinda required. + // This can delay the thread that it is running on. Bad but kinda required. while (_sessions.size() > 0) { std::this_thread::sleep_for(std::chrono::milliseconds(10)); } - _server.stop(); - _serverThread.join(); blog(LOG_INFO, "[Stop] Server stopped successfully");