From 6740e5fec738d82f741c9255c0528404d847551a Mon Sep 17 00:00:00 2001 From: tt2468 Date: Fri, 14 May 2021 01:44:59 -0700 Subject: [PATCH] Requests: Autorelease created scene in CreateScene Creating the scene increments the referenced scene by one, but we do not decrement it. This produces a memory leak which leads to the scene never being deleted after being removed from the UI. --- src/WSRequestHandler_Scenes.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/WSRequestHandler_Scenes.cpp b/src/WSRequestHandler_Scenes.cpp index 9fd837a4..9170d7a1 100644 --- a/src/WSRequestHandler_Scenes.cpp +++ b/src/WSRequestHandler_Scenes.cpp @@ -100,7 +100,8 @@ RpcResponse WSRequestHandler::CreateScene(const RpcRequest& request) { if (source) { return request.failed("scene with this name already exists"); } - obs_scene_create(sceneName); + obs_scene_t *createdScene = obs_scene_create(sceneName); + obs_scene_release(createdScene); return request.success(); }