From a3351be221fca6f75da72c9293d8cf43101c3359 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marcel=20M=C3=A4rtens?= Date: Tue, 12 Jan 2021 00:05:35 +0100 Subject: [PATCH] running `cargo check` with -D warnings seems to trigger a complete cache invalidation. AND cargo check was implicitly run in clippy. In order to be future save we now ALWAYS run all CI with -D warnings. (i verified that this works in a test pipeline) --- .gitlab-ci.yml | 3 ++- .gitlab/CI/check.gitlab-ci.yml | 4 ++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index bde49cf4d1..0e11b7a615 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -32,7 +32,8 @@ before_script: - export DISABLE_GIT_LFS_CHECK=true - export VELOREN_ASSETS="$(pwd)/assets" - echo "VELOREN_ASSETS=$VELOREN_ASSETS" - - rm -rf target || echo "some quickfix, idk why needed" + - export RUSTFLAGS="-D warnings" + - rm -rf target || echo "it seems that sometimes OLD data is left over" workflow: rules: diff --git a/.gitlab/CI/check.gitlab-ci.yml b/.gitlab/CI/check.gitlab-ci.yml index 6d13392255..247df426ff 100644 --- a/.gitlab/CI/check.gitlab-ci.yml +++ b/.gitlab/CI/check.gitlab-ci.yml @@ -3,8 +3,8 @@ check: stage: check script: - ln -s /dockercache/cache-all target - - RUSTFLAGS="-D warnings" cargo check --locked - - RUSTFLAGS="-D warnings" cargo check --examples --locked + - cargo check --locked + - cargo check --examples --locked code-quality: extends: .recompile-branch