From 2ff74f5cc9b2f47590da50d13875399245bc1557 Mon Sep 17 00:00:00 2001 From: "Dr. Dystopia" Date: Thu, 15 Jul 2021 13:46:53 +0200 Subject: [PATCH] Resolve all '#[allow(clippy::useless_format)]' error supressions --- server/src/cmd.rs | 3 --- voxygen/src/hud/bag.rs | 1 - voxygen/src/hud/map.rs | 3 +-- 3 files changed, 1 insertion(+), 6 deletions(-) diff --git a/server/src/cmd.rs b/server/src/cmd.rs index 71935ea43b..d61b79d3fd 100644 --- a/server/src/cmd.rs +++ b/server/src/cmd.rs @@ -1635,7 +1635,6 @@ fn handle_kit( #[allow(clippy::float_cmp)] // TODO: Pending review in #587 #[allow(clippy::needless_return)] // TODO: Pending review in #587 -#[allow(clippy::useless_format)] // TODO: Pending review in #587 fn handle_object( server: &mut Server, client: EcsEntity, @@ -1695,7 +1694,6 @@ fn handle_object( } } -#[allow(clippy::useless_format)] // TODO: Pending review in #587 fn handle_light( server: &mut Server, client: EcsEntity, @@ -2144,7 +2142,6 @@ fn handle_adminify( } #[allow(clippy::useless_conversion)] // TODO: Pending review in #587 -#[allow(clippy::useless_format)] // TODO: Pending review in #587 fn handle_tell( server: &mut Server, client: EcsEntity, diff --git a/voxygen/src/hud/bag.rs b/voxygen/src/hud/bag.rs index 112db80037..758cf0a59b 100644 --- a/voxygen/src/hud/bag.rs +++ b/voxygen/src/hud/bag.rs @@ -568,7 +568,6 @@ impl<'a> Widget for Bag<'a> { fn style(&self) -> Self::Style {} - #[allow(clippy::useless_format)] // TODO: Pending review in #587 fn update(self, args: widget::UpdateArgs) -> Self::Event { common_base::prof_span!("Bag::update"); let widget::UpdateArgs { state, ui, .. } = args; diff --git a/voxygen/src/hud/map.rs b/voxygen/src/hud/map.rs index b730475775..4b3e737574 100644 --- a/voxygen/src/hud/map.rs +++ b/voxygen/src/hud/map.rs @@ -194,7 +194,6 @@ impl<'a> Widget for Map<'a> { fn style(&self) -> Self::Style {} - #[allow(clippy::useless_format)] // TODO: Pending review in #587 fn update(self, args: widget::UpdateArgs) -> Self::Event { common_base::prof_span!("Map::update"); let widget::UpdateArgs { state, ui, .. } = args; @@ -960,7 +959,7 @@ impl<'a> Widget for Map<'a> { } else { size as f64 / 2.5 }; - Text::new(&format!("{}", title)) + Text::new(&title.to_string()) .x_y_position_relative_to( state.ids.map_layers[0], position::Relative::Scalar(rpos.x as f64),