From 5e8adb3c80fc73b4962ebeb964c33faa4415383b Mon Sep 17 00:00:00 2001 From: Imbris Date: Tue, 23 Aug 2022 02:12:28 -0400 Subject: [PATCH] Make the present mode default to Fifo instead of Immediate since it uses less power and in my own experience is generally a better experience when the GPU is under significant load. --- CHANGELOG.md | 1 + voxygen/src/render/mod.rs | 11 ++++------- 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 61d48402c2..e49e5f8bab 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -19,6 +19,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - Certain NPCs will now attack when alone with victim - /kill_npcs no longer leaves drops behind and also has bug causing it to not destroy entities fixed. +- Default present mode changed to Fifo (aka 'Vsync capped'). ### Removed diff --git a/voxygen/src/render/mod.rs b/voxygen/src/render/mod.rs index ebf5bd8d91..c0b7e4f2b1 100644 --- a/voxygen/src/render/mod.rs +++ b/voxygen/src/render/mod.rs @@ -251,16 +251,13 @@ impl Default for UpscaleMode { /// Present modes /// See https://docs.rs/wgpu/0.7.0/wgpu/enum.PresentMode.html -#[derive(PartialEq, Clone, Copy, Debug, Serialize, Deserialize)] +#[derive(Default, PartialEq, Clone, Copy, Debug, Serialize, Deserialize)] pub enum PresentMode { - Fifo, Mailbox, - #[serde(other)] Immediate, -} - -impl Default for PresentMode { - fn default() -> Self { Self::Immediate } + #[default] + #[serde(other)] + Fifo, // has to be last for `#[serde(other)]` } impl From for wgpu::PresentMode {