From 996f58ebd26421487865467523dba401e7151aa7 Mon Sep 17 00:00:00 2001 From: Imbris Date: Fri, 2 Jun 2023 20:30:43 -0400 Subject: [PATCH] Avoid using return for skipping respawn events --- server/src/sys/msg/in_game.rs | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/server/src/sys/msg/in_game.rs b/server/src/sys/msg/in_game.rs index a1e3d4bdf1..0c5f6a7a7e 100644 --- a/server/src/sys/msg/in_game.rs +++ b/server/src/sys/msg/in_game.rs @@ -102,15 +102,12 @@ impl Sys { } }, ClientGeneral::ControlEvent(event) => { - if presence.kind.controlling_char() { + if presence.kind.controlling_char() && let Some(controller) = controller { // Skip respawn if client entity is alive - if let ControlEvent::Respawn = event { - if healths.get(entity).map_or(true, |h| !h.is_dead) { - //Todo: comment why return! - return Ok(()); - } - } - if let Some(controller) = controller { + let skip_respawn = matches!(event, ControlEvent::Respawn) + && healths.get(entity).map_or(true, |h| !h.is_dead); + + if !skip_respawn { controller.push_event(event); } }