use super::{ sentinel::{DeletedEntities, ReadTrackers, TrackedComps}, SysTimer, }; use crate::{ client::{Client, RegionSubscription}, Tick, }; use common::{ comp::{ForceUpdate, Inventory, InventoryUpdate, Last, Ori, Pos, Vel}, msg::ServerMsg, region::{Event as RegionEvent, RegionMap}, state::TimeOfDay, sync::{CompSyncPackage, Uid}, }; use specs::{ Entities, Entity as EcsEntity, Join, Read, ReadExpect, ReadStorage, System, Write, WriteStorage, }; /// This system will send physics updates to the client pub struct Sys; impl<'a> System<'a> for Sys { #[allow(clippy::type_complexity)] // TODO: Pending review in #587 type SystemData = ( Entities<'a>, Read<'a, Tick>, ReadExpect<'a, TimeOfDay>, ReadExpect<'a, RegionMap>, Write<'a, SysTimer>, ReadStorage<'a, Uid>, ReadStorage<'a, Pos>, ReadStorage<'a, Vel>, ReadStorage<'a, Ori>, ReadStorage<'a, Inventory>, ReadStorage<'a, RegionSubscription>, WriteStorage<'a, Last>, WriteStorage<'a, Last>, WriteStorage<'a, Last>, WriteStorage<'a, Client>, WriteStorage<'a, ForceUpdate>, WriteStorage<'a, InventoryUpdate>, Write<'a, DeletedEntities>, TrackedComps<'a>, ReadTrackers<'a>, ); #[allow(clippy::redundant_closure)] // TODO: Pending review in #587 fn run( &mut self, ( entities, tick, time_of_day, region_map, mut timer, uids, positions, velocities, orientations, inventories, subscriptions, mut last_pos, mut last_vel, mut last_ori, mut clients, mut force_updates, mut inventory_updates, mut deleted_entities, tracked_comps, trackers, ): Self::SystemData, ) { timer.start(); let tick = tick.0; // To send entity updates // 1. Iterate through regions // 2. Iterate through region subscribers (ie clients) // - Collect a list of entity ids for clients who are subscribed to this // region (hash calc to check each) // 3. Iterate through events from that region // - For each entity entered event, iterate through the client list and // check if they are subscribed to the source (hash calc per subscribed // client per entity event), if not subscribed to the source send a entity // creation message to that client // - For each entity left event, iterate through the client list and check // if they are subscribed to the destination (hash calc per subscribed // client per entity event) // 4. Iterate through entities in that region // 5. Inform clients of the component changes for that entity // - Throttle update rate base on distance to each client // Sync physics // via iterating through regions for (key, region) in region_map.iter() { // Assemble subscriber list for this region by iterating through clients and // checking if they are subscribed to this region let mut subscribers = (&mut clients, &entities, &subscriptions, &positions) .join() .filter_map(|(client, entity, subscription, pos)| { if client.is_ingame() && subscription.regions.contains(&key) { Some((client, &subscription.regions, entity, *pos)) } else { None } }) .collect::>(); for event in region.events() { match event { RegionEvent::Entered(id, maybe_key) => { // Don't process newly created entities here (redundant network messages) if trackers.uid.inserted().contains(*id) { continue; } let entity = entities.entity(*id); if let Some((_uid, pos, vel, ori)) = uids.get(entity).and_then(|uid| { positions.get(entity).map(|pos| { (uid, pos, velocities.get(entity), orientations.get(entity)) }) }) { let create_msg = ServerMsg::CreateEntity(tracked_comps.create_entity_package( entity, Some(*pos), vel.copied(), ori.copied(), )); for (client, regions, client_entity, _) in &mut subscribers { if maybe_key .as_ref() .map(|key| !regions.contains(key)) .unwrap_or(true) // Client doesn't need to know about itself && *client_entity != entity { client.notify(create_msg.clone()); } } } }, RegionEvent::Left(id, maybe_key) => { // Lookup UID for entity if let Some(&uid) = uids.get(entities.entity(*id)) { for (client, regions, _, _) in &mut subscribers { if maybe_key .as_ref() .map(|key| !regions.contains(key)) .unwrap_or(true) { client.notify(ServerMsg::DeleteEntity(uid.into())); } } } }, } } // Sync tracked components // Get deleted entities in this region from DeletedEntities let (entity_sync_package, comp_sync_package) = trackers.create_sync_packages( &tracked_comps, region.entities(), deleted_entities .take_deleted_in_region(key) .unwrap_or_else(|| Vec::new()), ); let entity_sync_msg = ServerMsg::EntitySync(entity_sync_package); let comp_sync_msg = ServerMsg::CompSync(comp_sync_package); subscribers.iter_mut().for_each(move |(client, _, _, _)| { client.notify(entity_sync_msg.clone()); client.notify(comp_sync_msg.clone()); }); let mut send_msg = |msg: ServerMsg, entity: EcsEntity, pos: Pos, force_update: Option<&ForceUpdate>, throttle: bool| { for (client, _, client_entity, client_pos) in &mut subscribers { if if client_entity == &entity { // Don't send client physics updates about itself unless force update is set force_update.is_some() } else if !throttle { // Send the message if not throttling true } else { // Throttle update rate based on distance to client let distance_sq = client_pos.0.distance_squared(pos.0); let id_staggered_tick = tick + entity.id() as u64; // More entities farther away so checks start there if distance_sq > 300.0f32.powi(2) { id_staggered_tick % 32 == 0 } else if distance_sq > 250.0f32.powi(2) { id_staggered_tick % 16 == 0 } else if distance_sq > 200.0f32.powi(2) { id_staggered_tick % 8 == 0 } else if distance_sq > 150.0f32.powi(2) { id_staggered_tick % 4 == 0 } else if distance_sq > 100.0f32.powi(2) { id_staggered_tick % 2 == 0 } else { true // Closer than 100 blocks } } { client.notify(msg.clone()); } } }; // Sync physics components for (_, entity, &uid, &pos, maybe_vel, maybe_ori, force_update) in ( region.entities(), &entities, &uids, &positions, velocities.maybe(), orientations.maybe(), force_updates.maybe(), ) .join() { let mut comp_sync_package = CompSyncPackage::new(); let mut throttle = true; // TODO: An entity that stoppped moving on a tick that it wasn't sent to the // player will never have it's position updated match last_pos.get(entity).map(|&l| l.0 != pos) { Some(false) => {}, Some(true) => { let _ = last_pos.insert(entity, Last(pos)); comp_sync_package.comp_modified(uid, pos); }, None => { let _ = last_pos.insert(entity, Last(pos)); throttle = false; comp_sync_package.comp_inserted(uid, pos); }, } if let Some(&vel) = maybe_vel { match last_vel.get(entity).map(|&l| l.0 != vel) { Some(false) => {}, Some(true) => { let _ = last_vel.insert(entity, Last(vel)); comp_sync_package.comp_modified(uid, vel); }, None => { let _ = last_vel.insert(entity, Last(vel)); throttle = false; comp_sync_package.comp_inserted(uid, vel); }, } } else if last_vel.remove(entity).is_some() { // Send removal message if Vel was removed // Note: we don't have to handle this for position because the entity will be // removed from the client by the region system throttle = false; comp_sync_package.comp_removed::(uid); } if let Some(&ori) = maybe_ori { match last_ori.get(entity).map(|&l| l.0 != ori) { Some(false) => {}, Some(true) => { let _ = last_ori.insert(entity, Last(ori)); comp_sync_package.comp_modified(uid, ori); }, None => { let _ = last_ori.insert(entity, Last(ori)); throttle = false; comp_sync_package.comp_inserted(uid, ori); }, } } else if last_ori.remove(entity).is_some() { // Send removal message if Ori was removed throttle = false; comp_sync_package.comp_removed::(uid); } send_msg( ServerMsg::CompSync(comp_sync_package), entity, pos, force_update, throttle, ); } } // Handle entity deletion in regions that don't exist in RegionMap // (theoretically none) for (region_key, deleted) in deleted_entities.take_remaining_deleted() { for client in (&mut clients, &subscriptions) .join() .filter_map(|(client, subscription)| { if client.is_ingame() && subscription.regions.contains(®ion_key) { Some(client) } else { None } }) { for uid in &deleted { client.notify(ServerMsg::DeleteEntity(*uid)); } } } // TODO: Sync clients that don't have a position? // Sync inventories for (client, inventory, update) in (&mut clients, &inventories, &inventory_updates).join() { client.notify(ServerMsg::InventoryUpdate( inventory.clone(), update.event(), )); } // Remove all force flags. force_updates.clear(); inventory_updates.clear(); // Sync resources // TODO: doesn't really belong in this system (rename system or create another // system?) let tof_msg = ServerMsg::TimeOfDay(*time_of_day); for client in (&mut clients).join() { client.notify(tof_msg.clone()); } timer.end(); } }