Mirrored_Repos/wabbajack
1
0
Fork 0
mirror of https://github.com/wabbajack-tools/wabbajack.git synced 2024-08-30 18:42:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: CTD when paths are edited

Browse Source
This commit is contained in:
Timothy Baldridge 2022-08-22 10:28:11 -06:00
parent 9f1f2c009a
commit 5cfa111f7c
3 changed files with 19 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
CHANGELOG.md
View File

@ -1,5 +1,10 @@
### Changelog ### Changelog
#### Version - 3.0.0.5 -
* No longer rehashes files on every compile
* Editing paths in the install/compile settings won't crash the app
* Fix for .refcache files not being ignored during compilation
#### Version - 3.0.0.4 - 8/20/2022 #### Version - 3.0.0.4 - 8/20/2022
* Fix for: when some optional game files weren't present (like CreationKit.exe), the app would refuse to recognize any files from that game * Fix for: when some optional game files weren't present (like CreationKit.exe), the app would refuse to recognize any files from that game

2
Wabbajack.App.Wpf/Converters/AbsolutePathToStringConverter.cs
View File

@ -74,7 +74,7 @@ namespace Wabbajack
public object ConvertBack(object value, Type targetType, object parameter, CultureInfo culture) public object ConvertBack(object value, Type targetType, object parameter, CultureInfo culture)
{ {
return (AbsolutePath)(value as string); return AbsolutePath.ConvertNoFailure((string) value);
} }
} }
} }

14
Wabbajack.Paths/AbsolutePath.cs
View File

@ -47,7 +47,7 @@ public struct AbsolutePath : IPath, IComparable<AbsolutePath>, IEquatable<Absolu
if (path.StartsWith(@"\\")) if (path.StartsWith(@"\\"))
return PathFormat.Windows; return PathFormat.Windows;
if (DriveLetters.Contains(path[0]) && path[1] == ':') if (path.Length >= 2 && DriveLetters.Contains(path[0]) && path[1] == ':')
return PathFormat.Windows; return PathFormat.Windows;
throw new PathException($"Invalid Path format: {path}"); throw new PathException($"Invalid Path format: {path}");
@ -192,4 +192,16 @@ public struct AbsolutePath : IPath, IComparable<AbsolutePath>, IEquatable<Absolu
return Parent.Combine((FileName.WithoutExtension() + append).ToRelativePath() return Parent.Combine((FileName.WithoutExtension() + append).ToRelativePath()
.WithExtension(Extension)); .WithExtension(Extension));
} }
public static AbsolutePath ConvertNoFailure(string value)
{
try
{
return (AbsolutePath) value;
}
catch (Exception ex)
{
return default;
}
}
} }