From 63eaffd9e3f7576d727fd905df61a70da0544331 Mon Sep 17 00:00:00 2001 From: UrbanCMC Date: Wed, 9 Aug 2023 21:29:34 +0200 Subject: [PATCH] Remove duplicate user agent code --- Wabbajack.App.Wpf/LauncherUpdater.cs | 19 ++++++++-------- .../UserIntervention/OAuth2LoginHandler.cs | 10 ++++----- Wabbajack.Common/HttpExtensions.cs | 11 +++++++++- .../GoogleDriveDownloader.cs | 22 +++++++++---------- Wabbajack.Networking.Http/Extensions.cs | 7 ------ 5 files changed, 36 insertions(+), 33 deletions(-) diff --git a/Wabbajack.App.Wpf/LauncherUpdater.cs b/Wabbajack.App.Wpf/LauncherUpdater.cs index 94e7031e..96d3fd6b 100644 --- a/Wabbajack.App.Wpf/LauncherUpdater.cs +++ b/Wabbajack.App.Wpf/LauncherUpdater.cs @@ -8,6 +8,7 @@ using System.Threading.Tasks; using Microsoft.Extensions.Logging; using Microsoft.VisualBasic.CompilerServices; using Newtonsoft.Json; +using Wabbajack.Common; using Wabbajack.Downloaders; using Wabbajack.DTOs; using Wabbajack.DTOs.DownloadStates; @@ -27,9 +28,9 @@ namespace Wabbajack private readonly HttpClient _client; private readonly Client _wjclient; private readonly DTOSerializer _dtos; - + private readonly DownloadDispatcher _downloader; - + private static Uri GITHUB_REPO_RELEASES = new("https://api.github.com/repos/wabbajack-tools/wabbajack/releases"); public LauncherUpdater(ILogger logger, HttpClient client, Client wjclient, DTOSerializer dtos, @@ -41,8 +42,8 @@ namespace Wabbajack _dtos = dtos; _downloader = downloader; } - - + + public static Lazy CommonFolder = new (() => { var entryPoint = KnownFolders.EntryPoint; @@ -105,7 +106,7 @@ namespace Wabbajack var launcherFolder = KnownFolders.EntryPoint.Parent; var exePath = launcherFolder.Combine("Wabbajack.exe"); - + var launcherVersion = FileVersionInfo.GetVersionInfo(exePath.ToString()); if (release != default && release.version > Version.Parse(launcherVersion.FileVersion!)) @@ -119,7 +120,7 @@ namespace Wabbajack Name = release.asset.Name, Size = release.asset.Size }, tempPath, CancellationToken.None); - + if (tempPath.Size() != release.asset.Size) { _logger.LogInformation( @@ -130,12 +131,12 @@ namespace Wabbajack if (exePath.FileExists()) exePath.Delete(); await tempPath.MoveToAsync(exePath, true, CancellationToken.None); - + _logger.LogInformation("Finished updating wabbajack"); await _wjclient.SendMetric("updated_launcher", $"{launcherVersion.FileVersion} -> {release.version}"); } } - + private async Task GetReleases() { _logger.LogInformation("Getting new Wabbajack version list"); @@ -146,7 +147,7 @@ namespace Wabbajack private HttpRequestMessage MakeMessage(Uri uri) { var msg = new HttpRequestMessage(HttpMethod.Get, uri); - msg.UseChromeUserAgent(); + msg.AddChromeAgent(); return msg; } diff --git a/Wabbajack.App.Wpf/UserIntervention/OAuth2LoginHandler.cs b/Wabbajack.App.Wpf/UserIntervention/OAuth2LoginHandler.cs index 1d287022..51f45c7b 100644 --- a/Wabbajack.App.Wpf/UserIntervention/OAuth2LoginHandler.cs +++ b/Wabbajack.App.Wpf/UserIntervention/OAuth2LoginHandler.cs @@ -8,6 +8,7 @@ using System.Threading.Tasks; using System.Web; using Microsoft.Extensions.Logging; using ReactiveUI; +using Wabbajack.Common; using Wabbajack.DTOs.Interventions; using Wabbajack.DTOs.Logins; using Wabbajack.Messages; @@ -40,7 +41,7 @@ public abstract class OAuth2LoginHandler : BrowserWindowViewModel var tcs = new TaskCompletionSource(); await NavigateTo(tlogin.AuthorizationEndpoint); - + Browser!.Browser.CoreWebView2.Settings.UserAgent = "Wabbajack"; Browser!.Browser.NavigationStarting += (sender, args) => { @@ -50,7 +51,7 @@ public abstract class OAuth2LoginHandler : BrowserWindowViewModel tcs.TrySetResult(uri); } }; - + Instructions = $"Please log in and allow Wabbajack to access your {tlogin.SiteName} account"; var scopes = string.Join(" ", tlogin.Scopes); @@ -88,8 +89,7 @@ public abstract class OAuth2LoginHandler : BrowserWindowViewModel var msg = new HttpRequestMessage(); msg.Method = HttpMethod.Post; msg.RequestUri = tlogin.TokenEndpoint; - msg.Headers.Add("User-Agent", - "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/92.0.4515.159 Safari/537.36"); + msg.AddChromeAgent(); msg.Headers.Add("Cookie", string.Join(";", cookies.Select(c => $"{c.Name}={c.Value}"))); msg.Content = new FormUrlEncodedContent(formData.ToList()); @@ -101,6 +101,6 @@ public abstract class OAuth2LoginHandler : BrowserWindowViewModel Cookies = cookies, ResultState = data! }); - + } } \ No newline at end of file diff --git a/Wabbajack.Common/HttpExtensions.cs b/Wabbajack.Common/HttpExtensions.cs index 35ff173c..b2ca8d39 100644 --- a/Wabbajack.Common/HttpExtensions.cs +++ b/Wabbajack.Common/HttpExtensions.cs @@ -14,12 +14,21 @@ namespace Wabbajack.Common; public static class HttpExtensions { + private const string ChromeUserAgent = + "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/92.0.4515.159 Safari/537.36"; public static HttpRequestMessage AddCookies(this HttpRequestMessage msg, Cookie[] cookies) { msg.Headers.Add("Cookie", string.Join(";", cookies.Select(c => $"{c.Name}={c.Value}"))); return msg; } + public static HttpRequestMessage AddChromeAgent(this HttpRequestMessage msg, string? overrideUserAgent = null) + { + msg.Headers.UserAgent.Clear(); + msg.Headers.Add("User-Agent", overrideUserAgent ?? ChromeUserAgent); + return msg; + } + public static HttpRequestMessage AddHeaders(this HttpRequestMessage msg, IEnumerable<(string Key, string Value)> headers) { foreach (var header in headers) @@ -32,7 +41,7 @@ public static class HttpExtensions public static HttpRequestMessage ToHttpRequestMessage(this ManualDownload.BrowserDownloadState browserState) { var msg = new HttpRequestMessage(HttpMethod.Get, browserState.Uri); - msg.Headers.Add("User-Agent", browserState.UserAgent); + msg.AddChromeAgent(browserState.UserAgent); msg.AddCookies(browserState.Cookies); msg.AddHeaders(browserState.Headers); return msg; diff --git a/Wabbajack.Downloaders.GoogleDrive/GoogleDriveDownloader.cs b/Wabbajack.Downloaders.GoogleDrive/GoogleDriveDownloader.cs index 2dede342..c4906694 100644 --- a/Wabbajack.Downloaders.GoogleDrive/GoogleDriveDownloader.cs +++ b/Wabbajack.Downloaders.GoogleDrive/GoogleDriveDownloader.cs @@ -65,7 +65,7 @@ public class GoogleDriveDownloader : ADownloader iniData) { if (iniData.ContainsKey("directURL") && Uri.TryCreate(iniData["directURL"].CleanIniString(), UriKind.Absolute, out var uri)) @@ -74,8 +74,8 @@ public class GoogleDriveDownloader : ADownloader Priority.Normal; - - + + public async Task DownloadStream(Archive archive, Func> fn, CancellationToken token) { var state = archive.State as DTOs.DownloadStates.GoogleDrive; @@ -112,8 +112,8 @@ public class GoogleDriveDownloader : ADownloader c.Key.StartsWith("download_warning_")); @@ -124,7 +124,7 @@ public class GoogleDriveDownloader : ADownloaderGoogle Drive - Quota exceeded")) throw new Exception("Google Drive - Quota Exceeded"); - + doc.LoadHtml(txt); var action = doc.DocumentNode.DescendantsAndSelf() @@ -133,7 +133,7 @@ public class GoogleDriveDownloader : ADownloader d.GetAttributeValue("action", "")) .FirstOrDefault(); - if (action != null) + if (action != null) warning = ("download_warning_", "t"); } @@ -145,18 +145,18 @@ public class GoogleDriveDownloader : ADownloader GetJsonFromSendAsync(this HttpClient client, HttpRequestMessage msg, JsonSerializerOptions opts, CancellationToken? token = null) {