Mirrored_Repos/AppFlowy
1
0
Fork 0
mirror of https://github.com/AppFlowy-IO/AppFlowy.git synced 2024-08-30 18:12:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: popuplist will not show when the selection is not collapsed

Browse Source
This commit is contained in:
Lucas.Xu 2022-08-08 13:37:56 +08:00
parent 4a00f3c2ca
commit 849e19e1ef
1 changed files with 20 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
frontend/app_flowy/packages/flowy_editor/lib/service/internal_key_event_handlers/slash_handler.dart
View File

@ -72,16 +72,22 @@ FlowyKeyEventHandler slashShortcutHandler = (editorState, event) {
final rect = selectable.getCursorRectInPosition(selection.start);
final offset = selectable.localToGlobal(rect.topLeft);
if (!selection.isCollapsed) {
TransactionBuilder(editorState)
..deleteText(
textNode,
selection.start.offset,
selection.end.offset - selection.start.offset,
)
..commit();
}
TransactionBuilder(editorState)
..replaceText(textNode, selection.start.offset,
selection.end.offset - selection.start.offset, '/')
..commit();
_editorState = editorState;
WidgetsBinding.instance.addPostFrameCallback((_) {
showPopupList(context, editorState, offset);
});
return KeyEventResult.handled;
};
void showPopupList(
BuildContext context, EditorState editorState, Offset offset) {
_popupListOverlay?.remove();
_popupListOverlay = OverlayEntry(
builder: (context) => Positioned(
@ -97,16 +103,12 @@ FlowyKeyEventHandler slashShortcutHandler = (editorState, event) {
Overlay.of(context)?.insert(_popupListOverlay!);
editorState.service.selectionService.currentSelection
.removeListener(clearPopupListOverlay);
.removeListener(clearPopupList);
editorState.service.selectionService.currentSelection
.addListener(clearPopupListOverlay);
// editorState.service.keyboardService?.disable();
_editorState = editorState;
.addListener(clearPopupList);
}
return KeyEventResult.handled;
};
void clearPopupListOverlay() {
void clearPopupList() {
_popupListOverlay?.remove();
_popupListOverlay = null;
@ -215,7 +217,7 @@ class _PopupListWidgetState extends State<PopupListWidget> {
}
if (event.logicalKey == LogicalKeyboardKey.escape) {
clearPopupListOverlay();
clearPopupList();
return KeyEventResult.handled;
}