Mirrored_Repos/AppFlowy
1
0
Fork 0
mirror of https://github.com/AppFlowy-IO/AppFlowy.git synced 2024-08-30 18:12:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: import table from markdown (#4881)

Browse Source 
* fix: fixed error while importing table from markdown

* test: added test for the changes made

* fix: made changes from code review

* chore: remove the force unwrap code

---------

Co-authored-by: Lucas.Xu <lucas.xu@appflowy.io>
This commit is contained in:
Mukund-Tandon 2024-03-20 19:03:39 +05:30 committed by GitHub
parent 73df51f35f
commit 9201cd6347
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 56 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
frontend/appflowy_flutter/assets/test/workspaces/markdowns/markdown_with_table.md Normal file
View File

@ -0,0 +1,11 @@
# AppFlowy Test Markdown import with table
# Table
| S.No. | Column 2 |
| --- | --- |
| 1. | row 1 |
| 2. | row 2 |
| 3. | row 3 |
| 4. | row 4 |
| 5. | row 5 |

40
frontend/appflowy_flutter/integration_test/desktop/uncategorized/import_files_test.dart
View File

@ -1,5 +1,6 @@
import 'dart:io';
import 'package:appflowy_editor/appflowy_editor.dart';
import 'package:flutter/services.dart';
import 'package:flutter_test/flutter_test.dart';
import 'package:integration_test/integration_test.dart';
@ -44,5 +45,44 @@ void main() {
tester.expectToSeePageName('test1');
tester.expectToSeePageName('test2');
});
testWidgets('import markdown file with table', (tester) async {
final context = await tester.initializeAppFlowy();
await tester.tapGoButton();
// expect to see a getting started page
tester.expectToSeePageName(gettingStarted);
await tester.tapAddViewButton();
await tester.tapImportButton();
const testFileName = 'markdown_with_table.md';
final paths = <String>[];
final str = await rootBundle.loadString(
'assets/test/workspaces/markdowns/$testFileName',
);
final path = p.join(context.applicationDataDirectory, testFileName);
paths.add(path);
File(path).writeAsStringSync(str);
// mock get files
mockPickFilePaths(
paths: paths,
);
await tester.tapTextAndMarkdownButton();
tester.expectToSeePageName('markdown_with_table');
// expect to see all content of markdown file along with table
await tester.openPage('markdown_with_table');
final importedPageEditorState = tester.editor.getCurrentEditorState();
expect(importedPageEditorState.getNodeAtPath([0])!.type,
HeadingBlockKeys.type,);
expect(importedPageEditorState.getNodeAtPath([2])!.type,
HeadingBlockKeys.type,);
expect(importedPageEditorState.getNodeAtPath([4])!.type,
TableBlockKeys.type,);
});
});
}

10
frontend/appflowy_flutter/lib/plugins/document/application/document_data_pb_extension.dart
View File

@ -59,11 +59,11 @@ extension DocumentDataPBFromTo on DocumentDataPB {
// generate the meta
final childrenMap = <String, ChildrenPB>{};
blocks.forEach((key, value) {
final parentId = value.parentId;
if (parentId.isNotEmpty) {
childrenMap[parentId] ??= ChildrenPB.create();
childrenMap[parentId]!.children.add(value.id);
blocks.values.where((e) => e.parentId.isNotEmpty).forEach((value) {
final childrenId = blocks[value.parentId]?.childrenId;
if (childrenId != null) {
childrenMap[childrenId] ??= ChildrenPB.create();
childrenMap[childrenId]!.children.add(value.id);
}
});
final meta = MetaPB(childrenMap: childrenMap);