Mirrored_Repos/AppFlowy
1
0
Fork 0
mirror of https://github.com/AppFlowy-IO/AppFlowy.git synced 2024-08-30 18:12:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: remove useless onTap

Browse Source
This commit is contained in:
Cyrine-benabid 2022-10-30 20:19:20 +01:00
parent 8f1752a253
commit fad02eb09d
3 changed files with 0 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
frontend/app_flowy/lib/plugins/grid/presentation/widgets/common/text_field.dart
View File

@ -9,7 +9,6 @@ class InputTextField extends StatefulWidget {
final void Function(String)? onDone; final void Function(String)? onDone;
final void Function(String)? onChanged; final void Function(String)? onChanged;
final void Function() onCanceled; final void Function() onCanceled;
final void Function()? onTap;
final bool autoClearWhenDone; final bool autoClearWhenDone;
final String text; final String text;
final int? maxLength; final int? maxLength;
@ -20,7 +19,6 @@ class InputTextField extends StatefulWidget {
this.onDone, this.onDone,
required this.onCanceled, required this.onCanceled,
this.onChanged, this.onChanged,
this.onTap,
this.autoClearWhenDone = false, this.autoClearWhenDone = false,
this.maxLength, this.maxLength,
this.focusNode, this.focusNode,
@ -75,11 +73,6 @@ class _InputTextFieldState extends State<InputTextField> {
_controller.text = ""; _controller.text = "";
} }
}, },
onTap: () {
if (widget.onTap != null) {
widget.onTap!();
}
},
); );
} }

1
frontend/app_flowy/lib/plugins/grid/presentation/widgets/header/type_option/select_option.dart
View File

@ -256,7 +256,6 @@ class _AddOptionButton extends StatelessWidget {
fontSize: 12), fontSize: 12),
hoverColor: theme.hover, hoverColor: theme.hover,
onTap: () { onTap: () {
popoverMutex?.close();
context context
.read<SelectOptionTypeOptionBloc>() .read<SelectOptionTypeOptionBloc>()
.add(const SelectOptionTypeOptionEvent.addingOption()); .add(const SelectOptionTypeOptionEvent.addingOption());

7
frontend/app_flowy/packages/flowy_infra_ui/lib/widget/rounded_input_field.dart
View File

@ -19,7 +19,6 @@ class RoundedInputField extends StatefulWidget {
final TextStyle style; final TextStyle style;
final ValueChanged<String>? onChanged; final ValueChanged<String>? onChanged;
final Function(String)? onEditingComplete; final Function(String)? onEditingComplete;
final Function()? onTap;
final String? initialValue; final String? initialValue;
final EdgeInsets margin; final EdgeInsets margin;
final EdgeInsets padding; final EdgeInsets padding;
@ -40,7 +39,6 @@ class RoundedInputField extends StatefulWidget {
this.obscureHideIcon, this.obscureHideIcon,
this.onChanged, this.onChanged,
this.onEditingComplete, this.onEditingComplete,
this.onTap,
this.normalBorderColor = Colors.transparent, this.normalBorderColor = Colors.transparent,
this.errorBorderColor = Colors.transparent, this.errorBorderColor = Colors.transparent,
this.focusBorderColor, this.focusBorderColor,
@ -111,11 +109,6 @@ class _RoundedInputFieldState extends State<RoundedInputField> {
widget.onEditingComplete!(inputText); widget.onEditingComplete!(inputText);
} }
}, },
onTap: () {
if (widget.onTap != null) {
widget.onTap!();
}
},
cursorColor: widget.cursorColor, cursorColor: widget.cursorColor,
obscureText: obscuteText, obscureText: obscuteText,
style: widget.style, style: widget.style,