Mirrored_Repos/DisplayMagician
1
0
Fork 0
mirror of https://github.com/terrymacdonald/DisplayMagician.git synced 2024-08-30 18:32:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

[WIP] Partially fixed Profile.IsPossible logic

Browse Source 
The IsPossible logic in the ProfileItem incorrectly
uses the ToPathTargetInfo, when a better match is
to look for all the actual displays that are currently
turned on, and then allow all profiles that include
only the displays that are turned on. That involves
1. getting a list of the display devicepaths, and then
2. checking if this profile has all the devicepaths
needed to show the profile. If it does, then it
IsPossible.
This commit is contained in:
terrymacdonald
2020-07-24 21:46:53 +12:00
parent 5004f5f76a
commit 85de9b0697
1 changed files with 32 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

48
HeliosPlus.Shared/ProfileItem.cs
View File

@ -134,31 +134,47 @@ namespace HeliosPlus.Shared
{
get
{
List<string> unavailableDeviceNames = new List<string>();
// Then go through the displays in the profile and check they're live
foreach (ProfileViewport profileViewport in Viewports)
// Find the list of TargetDisplays we currently have from the currentprofile
List<string> availableDevicePaths = new List<string>();
ProfileViewport[] availableViewports = ProfileRepository.CurrentProfile.Viewports;
foreach (ProfileViewport availableViewport in availableViewports)
{
foreach (ProfileViewportTargetDisplay profileViewportTargetDisplay in profileViewport.TargetDisplays)
foreach (ProfileViewportTargetDisplay realTD in availableViewport.TargetDisplays)
{
PathTargetInfo viewportTargetInfo = profileViewportTargetDisplay.ToPathTargetInfo();
// If viewportTargetInfo is null, then this viewportTargetDisplay isn't currently available
// so this makes the profile invalid
if (viewportTargetInfo == null)
unavailableDeviceNames.Add(profileViewportTargetDisplay.DisplayName);
availableDevicePaths.Add(realTD.DevicePath);
}
}
if (unavailableDeviceNames.Count > 0)
{
// Darn - there was at least one unavilable displaytarget
// If there are no viewports, then return false
if (Viewports.Length == 0)
return false;
}
else
// Then go through the displays in the profile and check they are made of displays
// that currently are available.
foreach (ProfileViewport profileViewport in Viewports)
{
// There were no unavailable DisplayTargets!
return true;
// If there are no TargetDisplays in a viewport, then return false
if (profileViewport.TargetDisplays.Length == 0)
return false;
// For each profile, we want to make sure all TargetDisplays.DevicePath are in the list of
// availableDevicePaths
foreach (ProfileViewportTargetDisplay profileViewportTargetDisplay in profileViewport.TargetDisplays)
{
// Check this DevicePath is in the list of availableTargetDisplays
if (!availableDevicePaths.Contains(profileViewportTargetDisplay.DevicePath))
{
// profileViewportTargetDisplay is a display that isn't available right now
// This means that this profile is currently now possible
// So we return that fact to the calling function.
return false;
}
}
}
return true;
}
}