Mirrored_Repos/InvenTree
1
0
Fork 0
mirror of https://github.com/inventree/InvenTree synced 2024-08-30 18:33:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove maintenance mode wrapper from plugin loading (#6479)

Browse Source
This commit is contained in:
Oliver 2024-02-14 13:22:38 +11:00 committed by GitHub
parent 825366f684
commit 3637b28da7
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 7 additions and 38 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

45
InvenTree/plugin/registry.py
View File

@ -21,12 +21,6 @@ from django.urls import clear_url_caches, path
from django.utils.text import slugify
from django.utils.translation import gettext_lazy as _
from maintenance_mode.core import (
get_maintenance_mode,
maintenance_mode_on,
set_maintenance_mode,
)
from InvenTree.config import get_plugin_dir
from InvenTree.ready import canAppAccessDatabase
@ -218,11 +212,6 @@ class PluginsRegistry:
"""
logger.info('Loading plugins')
# Set maintenance mode
_maintenance = bool(get_maintenance_mode())
if not _maintenance:
set_maintenance_mode(True)
registered_successful = False
blocked_plugin = None
retry_counter = settings.PLUGIN_RETRY
@ -272,10 +261,6 @@ class PluginsRegistry:
# ensure plugins_loaded is True
self.plugins_loaded = True
# Remove maintenance mode
if not _maintenance:
set_maintenance_mode(False)
logger.debug('Finished loading plugins')
# Trigger plugins_loaded event
@ -292,21 +277,12 @@ class PluginsRegistry:
"""
logger.info('Start unloading plugins')
# Set maintenance mode
_maintenance = bool(get_maintenance_mode())
if not _maintenance:
set_maintenance_mode(True) # pragma: no cover
# remove all plugins from registry
self._clean_registry()
# deactivate all integrations
self._deactivate_plugins(force_reload=force_reload)
# remove maintenance
if not _maintenance:
set_maintenance_mode(False) # pragma: no cover
logger.info('Finished unloading plugins')
def reload_plugins(
@ -337,21 +313,14 @@ class PluginsRegistry:
collect,
)
_maintenance_mode = get_maintenance_mode()
if collect:
logger.info('Collecting plugins')
self.plugin_modules = self.collect_plugins()
with maintenance_mode_on():
if collect:
logger.info('Collecting plugins')
self.plugin_modules = self.collect_plugins()
self.plugins_loaded = False
self._unload_plugins(force_reload=force_reload)
self.plugins_loaded = True
self._load_plugins(full_reload=full_reload)
# Check if we wish to exit maintenance mode
if not _maintenance_mode:
set_maintenance_mode(False)
self.plugins_loaded = False
self._unload_plugins(force_reload=force_reload)
self.plugins_loaded = True
self._load_plugins(full_reload=full_reload)
self.update_plugin_hash()