setting for two password fields on signup

InvenTree/InvenTree/forms.py

@@ -231,8 +231,12 @@ class CustomSignupForm(SignupForm):
                 ),
             )
 
-            # reorder fields
-            set_form_field_order(self, ["username", "email", "email2", "password1", "password2", ])
+        # check for two password fields
+        if not InvenTreeSetting.get_setting('LOGIN_SIGNUP_PWD_TWICE'):
+            self.fields.pop("password2")
+
+        # reorder fields
+        set_form_field_order(self, ["username", "email", "email2", "password1", "password2", ])
 
     def clean(self):
         cleaned_data = super().clean()

InvenTree/InvenTree/settings.py

@@ -664,7 +664,6 @@ for app in SOCIAL_BACKENDS:
 # settings for allauth
 ACCOUNT_LOGOUT_ON_PASSWORD_CHANGE = True
 
-
 # override forms / adapters
 ACCOUNT_FORMS = {
     'login': 'allauth.account.forms.LoginForm',

InvenTree/common/models.py

@@ -864,6 +864,12 @@ class InvenTreeSetting(BaseInvenTreeSetting):
             'default': False,
             'validator': bool,
         },
+        'LOGIN_SIGNUP_PWD_TWICE': {
+            'name': _('Password twice'),
+            'description': _('On signup ask users twice for their password'),
+            'default': True,
+            'validator': bool,
+        },
     }
 
     class Meta:

InvenTree/templates/InvenTree/settings/login.html

@@ -23,6 +23,7 @@
             <td colspan='4'></td>
         </tr>
         {% include "InvenTree/settings/setting.html" with key="LOGIN_SIGNUP_MAIL_TWICE" icon="fa-info-circle" %}
+        {% include "InvenTree/settings/setting.html" with key="LOGIN_SIGNUP_PWD_TWICE" icon="fa-info-circle" %}
         {% include "InvenTree/settings/setting.html" with key="LOGIN_SIGNUP_SSO_AUTO" icon="fa-info-circle" %}
     </tbody>
 </table>