Mirrored_Repos/crafty-4
1
0
Fork 0
mirror of https://gitlab.com/crafty-controller/crafty-4.git synced 2024-08-30 18:23:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

Replace standard pseudo-random generators

Browse Source 
Resolves: `Bandit ID B311`
[Standard pseudo-random generators are not suitable for security/cryptographic purposes.]
This commit is contained in:
Zedifus 2022-06-03 14:05:26 +01:00
parent ba28369222
commit eaecb2f09b
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
app/classes/shared/helpers.py
View File

@ -8,7 +8,7 @@ import uuid
import string
import base64
import socket
import random
import secrets
import logging
import html
import zipfile
@ -722,8 +722,8 @@ class Helpers:
# create a self-signed cert
cert = crypto.X509()
cert.get_subject().C = "US"
cert.get_subject().ST = "Georgia"
cert.get_subject().L = "Atlanta"
cert.get_subject().ST = "Michigan"
cert.get_subject().L = "Kent County"
cert.get_subject().O = "Crafty Controller"
cert.get_subject().OU = "Server Ops"
cert.get_subject().CN = gethostname()
@ -743,7 +743,7 @@ class Helpers:
b"basicConstraints", True, b"CA:false"
)
cert.add_extensions([subject_alt_names_ext, basic_constraints_ext])
cert.set_serial_number(random.randint(1, 255))
cert.set_serial_number(secrets.randbelow(254) + 1)
cert.gmtime_adj_notBefore(0)
cert.gmtime_adj_notAfter(365 * 24 * 60 * 60)
cert.set_issuer(cert.get_subject())
@ -766,7 +766,7 @@ class Helpers:
random_generator() = G8sjO2
random_generator(3, abcdef) = adf
"""
return "".join(random.choice(chars) for x in range(size))
return "".join(secrets.choice(chars) for x in range(size))
@staticmethod
def is_os_windows():