crafty-4/CHANGELOG.md

Changelog

--- [4.3.1] - 2023/TBD

New features

TBD

Bug fixes

TBD

Tweaks

TBD

Lang

TBD

--- [4.3.0] - 2023/03/09

Breaking Changes

• This release includes database migrations that are not revertable. Once you update to this version you will not be able to rollback to a previous version.
• In this release, we've implemented a breaking change to enhance server identification within Crafty: instead of relying on numerical integers (1, 2, 3, etc.), Servers are now uniquely identified by their UUIDs. Please adapt your API clients accordingly.

Refactor

• Refactor remote file downloads (Merge Request)

Bug fixes

• Fix Bedrock cert issues (Merge Request)
• Make sure default.json is read from correct location (Merge Request)
• Do not allow users at server limit to clone servers (Merge Request)
• Fix bug where you cannot get to config with unloaded server (Commit)
• Fix forge install v1.20, 1.20.1 and 1.20.2 (Merge Request)
• Fix Sanitisation on Passwords (Merge Request | Merge Request)
• Fix Upload Imports on unix systems, that have a space in the root dir name (Merge Request)
• Fix Bedrock downloads, add www to download URL (Merge Request)
• Fire backup webhook 'after' backup has finished (Merge Request)

Tweaks

• Bump pyOpenSSL & cryptography for CVE-2024-0727, CVE-2023-50782 (Merge Request)
• Bump cryptography for CVE-2024-26130 (Merge Request)

Lang

• Update de_DE, en_EN, es_ES, fr_FR, he_IL, lol_EN, lv_LV, nl_BE pl_PL, th_TH, tr_TR, uk_UA, zh_CN translations for 4.3.0 (Merge Request)
  
  

--- [4.2.3] - 2023/02/02

New features

• Use Papermc Group's API for paper & folia builds in server builder (Merge Request)
• Allow omission of player count from Dashboard (e.g. for proxy servers) (Merge Request)
• Add lockout user for forgot password (Merge Request | Merge Request)

Refactor

• Refactor subpage perm checks (Merge Request)

Bug fixes

• [CVE-2024-1064] Security-related fix to resolve an issue with the HTTP listener (Merge Request)
• Fix bukkit and downstream fork MOTD crash (Merge Request)
• Fix bug where invalid server Id leads to stack (Merge Request)
• Fix indent on public status check box (Merge Request)
• Fix unicode chars in terminal & logs w/ textiowrapper (Merge Request)
• Provide feedback on file delete failure (Merge Request)
• Fix bug where audit log would show 0 for any stdin sent to the server (Merge Request)

Tweaks

• Refactor Forge server initialisation flow for newer versions (Merge Request)
• Remove scroll bars from player management (Merge Request)
• Add warning to wizard for unsupported mc (Merge Request)
• Improve display for th-TH characters (Merge Request)
• Improve display of white text on wssErrors (Merge Request | 50e65f6)
• Improve display of white text on Buttons (Merge Request)
• Fix dashboard motd issue #322 (Merge Request)

Lang

• Update zh_CN, pl_PL, nl_BE, lv_LV, he_IL, fr_FR, de_DE, lol_EN translations for 4.2.3 (Merge Request)
• New uk_UA, tr_TR, th_TH translations for 4.2.3 (Merge Request)
  
  

--- [4.2.2] - 2023/12/13

New features

• Loading Screen for Crafty during startup (Merge Request)

Refactor

• Remove deprecated API V1 (Merge Request)
• Tidy up main.py to be more comprehensive (Merge Request)
• Force random password on first run. Stop using common default password (Merge Request | Merge Request)

Bug fixes

• Remove webhook custom option from webook provider list as it's not currently an option (Merge Request)
• Bump cryptography for CVE-2023-49083 (Merge Request)
• Fix bug where su cannot edit general user password (Merge Request)
• Fix bug where no file error on import root dir (Merge Request)
• Fix Unban button failing to pardon users (Merge Request)
• Fix stack in API error handling (Merge Request)
• Fix bug where you cannot select "do not monitor mounts" from config.json (Merge Request)
• Fix support log 'x' button still downloading logs (Merge Request)
• Fix bug where servers are created without bu dir (Merge Request)

Tweaks

• Homogenize Panel logos/branding (Merge Request)
• Retain previous tab when revisiting server details page (#272)(Merge Request)
• Add server name tag in panel header (#272)(Merge Request)
• Setup logging for panel authentication attempts (Merge Request)
• Update minimum password length from 6 to 8, and unrestrict maximum password length (Merge Request)
• Give better feedback when backup delete fails (Merge Request)
• Add user queue debug logging (Merge Request)

Lang

• Update de_DE, en_EN, fr_FR, lol_EN, lv_LV, nl_BE, pl_PL, zh_CN translations for 4.2.2 (Merge Request)
• Mark es_ES as incomplete (Merge Request)
• Mark he_IL as active (Merge Request)
• pl_PL Minor fixes (Merge Request)
  
  

--- [4.2.1] - 2023/11/01

Bug fixes

• Fix logic issue with get_files API permissions check (Merge Request)
• Fix notifications not showing up/being reset #298 (Merge Request)
• Fix users not being able to be deleted since the prompt fails to display (Merge Request)
• Fix duplicate function naming on dashboard (Merge Request)

Tweaks

• Auto refresh Crafty Announcements on 30m interval (Merge Request)
• Improve Crafty toggle buttons and Webhooks page (Merge Request)

Lang

• Update zh_CN lang file (Merge Request)
• Update es_ES lang file (Merge Request)
• Clean up wording in pl_PL lang file (Merge Request)
• Add de_DE, es_ES fr_FR, lol_EN, lv_LV, nl_BE pl_PL & zh_CN translations for !656 (Merge Request)

Docs

• (New) Server Webhook Documentation
• (Edit) Image Context in Windows Service - Install steps, with slight wording improvement
  
  

--- [4.2.0] - 2023/10/18

New features

• Finish and Activate Arcadia notification backend (Merge Request | Merge Request | Merge Request)
• Add initial Webhook Notification (Discord, Mattermost, Slack, Teams) (Merge Request)
• Implementation of OpenMetrics endpoints, for use with services such as Prometheus (Merge Request)

Bug fixes

• PWA: Removed the custom offline page in favour of browser default (Merge Request)
• Fix hidden servers appearing visible on public mobile status page (Merge Request)
• Correctly handle if a server returns a string instead of json data on socket ping (Merge Request)
• Bump tornado to resolve #269 (Merge Request)
• Bump crypto to resolve #267 & #268 (Merge Request)
• Fix select installs failing to start, returning missing python package packaging (Merge Request)
• Fix public status page not updating #255 (Merge Request)
• Fix service worker vulrn and CQ raised by SonarQ (Merge Request)
• Fix Backup Restore/Schedules, Backup button function on remote-comms2 (Merge Request)
• Add a wait to the call for the directory so we can make sure the wait dialogue has time to show up first (Merge Request)
• Fix bug where a reaction loop could be created, but would be cut short by an error when the loop occurred (Merge Request)
• Use controller on update user call (Merge Request)
• Move imports to import/upload in bind mount to better serve users on unraid with limited vdisk storage (Merge Request)
• Fix bug where everytime a page was loaded user settings would be reset #286 (Merge Request)
• Fix tooltip info icon on server config page (Merge Request)
• Fix quick disable toggle on schedules list (Merge Request)

Refactor

• Consolidate remaining frontend functions into API V2, and remove ajax internal API (Merge Request)
• Replace bleach with nh3 (Merge Request)
• Add API route for historical server stats (Merge Request)
• Add API route for host stats (Merge Request)

Tweaks

• Polish/Enhance display for InApp Documentation (Merge Request)
• Add get_users command to Crafty's console (Merge Request)
• Make files hover cursor pointer (Merge Request)
• Use Jar class naming for jar refresh to make room for steamCMD naming in the future (Merge Request)
• Improve ui visibility of Build Wizard selection tabs (Merge Request)
• Add additional logging for server bootstrap & moves unnecessary logging to debug for improved log clarity (Merge Request)
• Bump orjson to 3.9.7 for python 3.12 support (Merge Request)
• Bump all Crafty required python dependancies, maintaining minimum 3.9 support (Merge Request) Revert peewee bump (Merge Request)
• Better optimize and refactor docker launcher sh (Merge Request)
• Improve pop-up notifications with Toasts (Merge Request)
• Move username and password settings to buttons on panel config (Merge Request)
• Remove external references from front end deps (Merge Request)

Lang

• fr_FR Translation Updated to latest en_EN (Merge Request)
• de_DE, fr_FR, lol_EN, lv_LV, nl_BE, pl_PL Translations Updated to latest en_EN (Merge Request)
  
  

--- [4.1.3] - 2023/07/18

Bug fixes

• Include tzdata in Docker image (Merge Request)
• Fix text/formatting issue on server config page (Merge Request)
• Bump required version of PyYAML to 6.0.1 (Merge Request)
• Fix enable/disable schedule toggles on schedule list (Merge Request)
• Fix formatting on Creation page when server jars is unavailable (Merge Request)

Refactor

• Replace "in_file" helper method (Merge Request)

Tweaks

• Add public status link to login (Merge Request)
  
  

--- [4.1.2] - 2023/06/18

Bug fixes

• Fix upload root files being hidden (Merge Request)
• Send empty json for no banned/cached players (Merge Request)
• Bump Tornado from 6.0 to 6.3.2 in response to CVE-2023-28370 (Merge Request)
• Fix bug where commands would show "command_server" when initially created (Merge Request)
• Add ID autofield to management CraftySettings class (Merge Request)

Refactor

• Optimize player management page (Merge Request)

Tweaks

• Remove bedrock servers in serverjars options (Merge Request)
• Bump cryptography & pyOpenSSL (Merge Request)
• Bump requests (Merge Request)

Lang

• Update es_ES & pl_PL lang, thank you .lucyy_ & terrariadlc (Merge Request)
  
  

--- [4.1.1] - 2023/05/23

Bug fixes

• Fix task scheduling where a command was not sent to the DB (Merge Request)

Tweaks

• Improve the UI on several areas of the Crafty Panel (Merge Request)
• Improve creation page errors / Server Jars Credit (Merge Request)
  
  

--- [4.1.0] - 2023/05/15

New features

• Mobile PWA App (beta) | Ability to add a Crafty icon to your mobile's home screen (Merge Request)
• New Crafty Documentation release

Refactor

• Frontend Ajax Refactor | Start using API to send Remote Comms to Server (Merge Request)
• MKDocs Release | Replace wiki names with docs (Merge Request)

Bug fixes

• Fix pipelines failing to build from gitlab pre-defined variable deprecation (Merge Request)
• Fix incompatible buildx provenance meta, causing digest issues on GL/DH container registries (Merge Request)
• Fix Auth'd servers in roles | Refine server ordering (Merge Request)
• Fix import loop detection (Merge Request)
• Fix Cargo errors on Ubuntu 23.04 installs (Merge Request)
• Fix project root error on first start (Merge Request)

Tweaks

• Check for python version so we don't just fail out on unsupported python versions (Merge Request)
• Show warning for serverjars API connection issues (Merge Request)
• Retain pathing in execution command on backup restore (Merge Request)
  
  

--- [4.0.22] - 2023/04/08

Bug fixes

• Fix dashboard crash for users without disks or if crafty doesn't have permission to access mount point (Merge Request)
• Strip Minecraft motd obfuscation chars to prevent text jumping on dashboard (Merge Request)

Tweaks

• Improve logging on tz failures (Merge Request)
• Add fallback for ping domain to provide better feedback on internet connection (Merge Request)
  
  

--- [4.0.21] - 2023/03/04

New features

• Add better feedback for uploads with a progress bar (Merge Request)
• Add ignored exit codes for crash detection (Merge Request)
• Allow users to change the directory where Crafty Stores Servers (Merge Request)
  (Only for non-docker, docker users should change host volume mount)
• Add host storage display option to the dashboard (Merge Request)

Bug fixes

• Fix exception related to page data on server start (Merge Request)
• Fix logical issue with uploading dynamic files (Merge Request)
• Fix backups failing by correctly using tz objects (Merge Request)
• Bump Cryptography/pyOpenSSL for CVE-2023-23931 (Merge Request)
• Fix debug logging to only display with the -v (verbose) flag (Merge Request)
• Optimize world size calculation (Merge Request)
• Only copy bedrock_server executable on update (Merge Request)
• Fix bug where unloaded servers could not be deleted (Merge Request)
• Fix bug where "servers" was not appended (Merge Request)

Tweaks

• Cleanup authentication helpers (Merge Request)
• Optimize file upload progress WS (Merge Request)
• Truncate sidebar servers to a max of 10 (Merge Request)
• Upgrade to FA 6. Add Translations (Merge Request)(Merge Request)
• Forge installer and Java Detection improvements (Merge Request)
• Crafty log clean up -config option (Merge Request)

Lang

• Add additional translations to backups page strings (Merge Request)
• Add additional missing translations (Merge Request)
  
  

--- [4.0.20] - 2023/01/29

New features

• Add option to run command before backup. (Merge Request)
• Make Config.json editable from panel. (Merge Request)
• Managed config.json refector (See MR for details). (Merge Request)

Bug fixes

• Fix local java server imports. (Merge Request)
• Fix Schedule Restore | Add Backup Config Preservation. (Merge Request)
• Rework /public Route. (Merge Request)

Tweaks

• Hide stats DB directory from files tree. (Merge Request)
• Make it so file tree doesn't reload on upload/delete. (Merge Request)
• Add upload completed feedback to file upload. (Merge Request)
• Added further login screen customisation settings. (Merge Request)
• Set backup filename to use same time as schedule. (Merge Request)
• Move Schedules to from DB to Queue Datatype. (Merge Request)
• Move raknet icon failure to a debug log. (Merge Request)
• Add Default redirection to Dashboard if the user is connected. (Merge Request)
  
  

--- [4.0.19] - 2023/01/07

Bug fixes

• Fix port tooltip not showing on dash while server online. (Merge Request)
• Fix '+' char in path causing any file operation to fail. (Merge Request)
• Fix colours on public pages. (Merge Request)
• Fix bug where public background was not sent to public pages...like the error page resulting in an error...ironic...I know. (Merge Request)
• Be sure a user cannot server import crafty dir. (Merge Request)
• Remove Pathlib from sub path check (Merge Request)
• Fix root dir selection in Upload Zip Import (Merge Request)
• Fix stats error on mac M1 chips (Merge Request)
• Fix window path escape on java override (Merge Request)
• Fix Forge import stalling on 1.17 Forge servers (Merge Request)
• Fix issue with server config for SU Accounts (Merge Request)
• Fix Nested reaction tasks (Merge Request)
• Remove legacy unzip code causing issues with single file zip files (Merge Request)

Tweaks

• Make server directories non-configurable (Merge Request)
• Add popover to server port to detail it's purpose (Merge Request)
• Add server start timeout w/ WS Warning (Merge Request)
• Replace google ping for ntp for internet checks in locked-down countries (Merge Request)
• Add pushing to DockerHub registry (arcadiatechnology/crafty-4) (Merge Request)

Lang

• Added Czech translation (Merge Request)
  
  

--- [4.0.17/4.0.18] - 2022/11/30

New features

• Automate forge install process through Crafty server creation for Forge server version 1.16 and greater. (Merge Request)
• Tooltip for server port on dashboard. (Merge Request)
• Custom login image backgrounds. (Merge Request)

Bug fixes

• Fix no port on bedrock server creation. (Merge Request)

Tweaks

• Docker🐋 | Update image base to Ubuntu 22.04 Jammy. (Merge Request)
  (OpenJDK16 Removed, no jammy backport)

Hotfix (4.0.18)

• Apply custom login backgrounds on all public pages. (Merge Request)
  
  

--- [4.0.16] - 2022/10/23

New features

• Automatically set update url for (new) server creation (Merge Request)
• Add filter to logs panel (Merge Request)

Bug fixes

• Fix conditional issue with zip imports/uploads (Merge Request)
• Fix API Schedule updates (Merge Request)
• Add port constraint for all server creation & api (Merge Request)
• Clean up backup configs when deleting servers (Merge Request)
• Add timeout to socket for servers with incorrect port selection (Merge Request)
• Fix server_stats db file when deleting server (Merge Request)
• Fix "cannot render after finish" from backup_now (Merge Request)
• Fix Support Logs on windows by changing the way we declare projects working directory (Merge Request | Commit)

Tweaks

• Fix sidebar to not move when scrolling (Merge Request)
• Add the rest of CSS predefined colors to themes (Merge Request)
• Only send realtime stats when clients connected (Merge Request)
  
  

--- [4.0.15] - 2022/10/02

New features

• Base Theme Switching (Dark, Light, Default) 🤩🎨 (Merge Request)
• Upload Zip functionality for server imports 🏗️🎉 (Merge Request)

Bug fixes

• Fix traceback on basic schedule with "days" interval (Merge Request)
• Fix bad method call with API stdin (Merge Request)
  (Thank you 'IWant2Tryhard' for catching that 🐛)
• Fix clients variable as static to prevent crash if client list changed while sending a websocket (Merge Request)
  
  

--- [4.0.14] - 2022/09/23

Bug fixes

• HOTFIX - Rollback breaking websockets change !461 (self.clients was already a set and we tried to subscript a set of a set) (Merge Request)
  
  

--- [4.0.13] - 2022/09/20

Bug fixes

• Fix bug where trying to reconfigure unloaded server would stack (Commit | Merge Request)
• Fix traceback error when a user click the roles config tab while already on the roles config page; this is for new role creation only (Merge Request)
• Fix logic issue when removing items from backup exclusions (Merge Request)
• Cleanup various JS errors (Merge Request)
• Temp fix for & issue in pathing and minecraft colour codes (Merge Request)
• Cache Gravatar pfp's as to not query every page load (Merge Request)
• Fix crash on client list changing while sending websockets (Merge Request)
• Set default parent option on edit of reaction schedule (Merge Request)
• Fix wtol Nonetype error on server start when 'which java' returns none (Merge Request)

Tweaks

• Add button to scroll to bottom of vterm (Merge Request)
• Persist schedules and execution commands across backup restores (Merge Request)

Release Testing- Bug fixes

• Fix bug with logical issues surrounding gravatar caching (Merge Request)
• Fix bug where server terminal would not scroll on startup (Merge Request)
• Fix issue on post with adding users when no email is included (this also affected editing users) (Merge Request)
• Fix issue with schedules allowing days to be more than 30 (Merge Request)
• Fix issue with schedules when trying to edit a cron task (Merge Request)
  
  

--- [4.0.12] - 2022/09/04

New features

• Win Portable Updater will now be included in Windows Package (Merge Request)
• Bedrock Server Creator (Merge Request)

Bug fixes

• Fix performance issues on server metrics panels 'with metrics range' (Merge Request) (Merge Request)
• Fix no id on import3 servers (Merge Request)
• Fix functionality of bedrock update (Merge Request)
• Fix mc-ping Traceback (Merge Request)

Tweaks

• Flatten input on password resets (Merge Request)
  
  

--- [4.0.11] - 2022/08/28

New features

• Add server import status indicators (Merge Request)
• Users can now be assigned as manager of other users/roles (Merge Request)
• Add variable shutdown timeouts (Merge Request)
• Add server metrics graph (Merge Request)

Bug fixes

• Fix creation quota not refilling after server delete (Merge Request)
• Add missing bedrock dependency (libcurl.so.4) (Merge Request)

Tweaks

• Make imports threaded (Merge Request)
• Add 'Created By' Field to servers (Merge Request)
• Add Zip comments to support archives (Merge Request)
  
  

--- [4.0.10] - 2022/08/14

Bug fixes

• Fix reaction tasks not firing (Merge Request)
• QOL task delay offset not following over on task edit (Merge Request)
• Fix Fresh Install Detection Logic issues (Merge Request)
• Fix reload issue on backup panel - on certain browsers (Merge Request)
• Fix '&' in backup paths (Merge Request)

Tweaks

• Session Handling | Logout on browser close (Merge Request)
• Backups Panel | Only display zips (Merge Request)
• User creation | Fix page browser title (Merge Request)
  
  

--- [4.0.9] - 2022/08/06

Bug fixes

• Fix Schedules Traceback Bug (Merge Request | Commit | Commit)
• Fix handling of missing servers (Merge Request🎉)
• Fix offline credits panel stack (Commit)

Tweaks

• credits-v2| Translator status (Merge Request)
• Use Names in Schedules (Merge Request)

Lang

• Make Schedules panel translatable (Merge Request)
  
  

--- [4.0.8] - 2022/08/05

New features

• Add Crafty Version Check and notification (Merge Request)

Bug fixes

• Fix SU status not sticking on user creation (Merge Request)
• Handle Missing Java From Win Registry (Merge Request)
• Disable restart while server is backing up (Merge Request)
• Fix server creation with serverjars API (Merge Request)
• Fix API Key delete confirmations (Merge Request)

Tweaks

• Add next run to schedule info (Merge Request)

Lang

• Updated es_ES (Merge Request)
• Added pl_PL (Merge Request)
  
  

--- [4.0.7] - 2022/07/18

New features

• Task toggle (Merge Request)
• Basic API for modifying tasks (Merge Request)
• Toggle Visible servers on status page (Merge Request)

Bug fixes

• Fixes stats recording for Oracle hosts (Merge Request)
• Improve use of object oriented architecture (Merge Request)
• Fix issue with API Server Instance is not serializable (Merge Request)
• Fix issue where the motd was not displayed properly on small screens (Merge Request)
• Fix log file path issues caused by using relative paths (Merge Request)
• Fix servers order on creation page (Merge Request)

Tweaks

• Remove server.props requirement (Merge Request)
• Add platform & crafty version info to support logs (Merge Request)

Lang

• Updated fi_FI, fr_FR, he_IL, lv_LV, nl_BE, zh_CN, id_ID, lol_EN (Merge Request)
• Added pt_BR (Merge Request)
• Sorted/Corrected en_EN (Merge Request)
  
  

--- [4.0.6] - 2022/07/06

Bug fixes

• Remove redundant path check on backup restore (Merge Request)
• Fix issue with stats pinging on slow starting servers (Merge Request)
• Fix unhandled exeption when serverjars api returns 'None' (Merge Request)
• Fix ajax issue with unzip on firefox (Merge Request)
• Turn off verbose logging on Docker (Merge Request)
• Refactor tempdir from packaging logs (Commit)

Tweaks

• Remove autofill on user form (Merge Request)
• Confirm username does not exist on edituser (Merge Request)
• Check for passwords matching on client side (Merge Request)

Lang

• Add string "cloneConfirm" to german translation (Merge Request)
  
  

--- [4.0.5] - 2022/06/24

New features

None

Bug fixes

• Fix cannot delete backup on page 2 (Merge Request)
• Fix server starting up without stats monitoring after backup shutdown. (Merge Request)
• Fix pathing issue when launching with just "java" (Merge Request)
• Fix path issue with update-alternatives (Merge Request)

Tweaks

• Rework server list on status page display for use on small screens (Merge Request)
• Add clone server confirmation (Merge Request)

Lang

• German translation review, fixed some spelling issues and added some missing strings (Merge Request)
  
  

--- [4.0.4-hotfix2] - 2022/06/21

Bug fixes

• Fix Traceback on schedule config page (Merge Request)
  
  

--- [4.0.4-hotfix] - 2022/06/21

Bug fixes

• Remove bad check for backups path (Merge Request)
  
  

--- [4.0.4] - 2022/06/21

New features

• Add shutdown on backup feature (Merge Request)
• Add detection and dropdown of java versions (Merge Request)
• Add file-editor size toggle (Merge Request)

Bug fixes

• Backup/Config.json rework for API key hardening (Merge Request)
• Fix stack on ping result being falsy (Merge Request)
• Fix sec bug with server creation roles (Merge Request)

Tweaks

• Spelling mistake fixed in German lang file (Merge Request)
• Backup failure warning (Tab text goes red) (Merge Request)
• • (Merge Request 2)
• Rework server list on dashboard display for use on small screens (Merge Request)
• File handling enhancements (Merge Request)
  
  

--- [4.0.3] - 2022/06/18

New features

• Integrate Wiki iframe into panel instead of link (Merge Request)

Bug fixes

• Amend Java system variable fix to be more specfic since they only affect Oracle. (Merge Request)
• API Token authentication hardening (Merge Request)

Tweaks

• Add better error logging for statistic collection (Merge Request)
  
  

--- [4.0.2-hotfix1] - 2022/06/17

Crit Bug fixes

• Fix blank server_detail page for general users (Merge Request)
  
  

--- [4.0.2] - 2022/06/16

New features

None

Bug fixes

• Fix winreg import pass on non-NT systems (Merge Request)
• Make the WebSocket automatically reconnect. (Merge Request)
• • (Merge Request 2)
• Add version inheretence & config check (Merge Request)
• Fix support log temp file deletion issue/hang (Merge Request)
  
  

--- [4.0.1] - 2022/06/15

New features

None

Bug fixes

• Remove session.lock warning (Merge Request)
• Correct Dutch Spacing Issue (Merge Request)
• Remove no-else-* pylint exemptions and tidy code. (Merge Request)