Mirrored_Repos/veloren
1
0
Fork 0
mirror of https://gitlab.com/veloren/veloren.git synced 2024-08-30 18:12:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix some comments that were mis-formatted by rustfmt

Browse Source 
and remove TODO that is now documented as a review comment
This commit is contained in:
Imbris 2022-11-14 22:21:45 -05:00
parent 07d3242b26
commit 132ce72246
1 changed files with 11 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
voxygen/src/render/pipelines/ui.rs
View File

@ -416,21 +416,21 @@ pub fn create_tri(
// 1. Upload new image via `Device::create_texture_with_data`.
//
// (NOTE: Initially considered: Creating a storage buffer to read from in the
// shader via `Device::create_buffer_init`, with `MAP_WRITE` flag to avoid
// staging buffer. However, with dedicated GPUs combining usages other than
// `COPY_SRC` with `MAP_WRITE` may be less ideal. Plus, by copying into a
// texture first we can get free srgb conversion when fetching colors
// from the texture. In the future, we may want to branch based on the
// whether the GPU is integrated and avoid this extra copy.)
// shader via `Device::create_buffer_init`, with `MAP_WRITE` flag to avoid
// staging buffer. However, with GPUs combining usages other than `COPY_SRC`
// with `MAP_WRITE` may be less ideal. Plus, by copying into a texture first
// we can get free srgb conversion when fetching colors from the texture. In
// the future, we may want to branch based on the whether the GPU is
// integrated and avoid this extra copy.)
//
// 2. Run render pipeline to multiply by alpha reading from this texture and
// writing to the final texture (this can either be in an atlas or in an
// independent texture if the image is over a certain size threshold).
// writing to the final texture (this can either be in an atlas or in an
// independent texture if the image is over a certain size threshold).
//
// (NOTE: Initially considered: using a compute pipeline and writing to the
// final texture as a storage texture. However, the srgb format can't be used
// with storage texture and there is not yet the capability to create
// non-srgb views of srgb textures.)
// final texture as a storage texture. However, the srgb format can't be
// used with storage texture and there is not yet the capability to create
// non-srgb views of srgb textures.)
//
// Info needed:
//