Mirrored_Repos/veloren
1
0
Fork 0
mirror of https://gitlab.com/veloren/veloren.git synced 2024-08-30 18:12:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge branch 'fotkurz/plugin-bookkeepingoptimization' into 'master'

Browse Source 
Fix #1968: refactor missing_plugins check for better performance

Closes #1968

See merge request veloren/veloren!4463
This commit is contained in:
Marcel 2024-05-17 22:15:40 +00:00
commit 246d90cf22
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
client/src/lib.rs
View File

@ -3248,8 +3248,8 @@ impl Client {
self.missing_plugins.len()
}
/// number of requested plugins
pub fn num_missing_plugins(&self) -> usize { self.missing_plugins.len() }
/// true if missing_plugins is not empty
pub fn are_plugins_missing(&self) -> bool { !self.missing_plugins.is_empty() }
/// extract list of locally cached plugins to load
pub fn take_local_plugins(&mut self) -> Vec<PathBuf> { std::mem::take(&mut self.local_plugins) }

2
voxygen/src/menu/char_selection/mod.rs
View File

@ -71,7 +71,7 @@ impl CharSelectionState {
impl PlayState for CharSelectionState {
fn enter(&mut self, global_state: &mut GlobalState, _: Direction) {
// Load the player's character list
if self.client.borrow().num_missing_plugins() == 0 {
if !self.client.borrow().are_plugins_missing() {
self.client.borrow_mut().load_character_list();
}