Mirrored_Repos/veloren
1
0
Fork 0
mirror of https://gitlab.com/veloren/veloren.git synced 2024-08-30 18:12:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

switch from read to read_buf in tcp sink. also always reserve 4 times 1500 as soon as we are under 1500 bytes in order to have less allocations when sending many small msg.

Browse Source 
Note: maybe upgrading tokio helps against the connection issues, there is some mio related stuff: https://github.com/tokio-rs/tokio/releases/tag/tokio-1.18.0
Note: quick also still has the old read, but its more complicated, thus i only want to change it if its tested
This commit is contained in:
Marcel Märtens 2022-06-21 16:57:31 +02:00
parent 4e6e754494
commit 3da053c8b4
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
network/src/channel.rs
View File

@ -494,13 +494,15 @@ impl UnreliableSink for TcpSink {
type DataFormat = BytesMut;
async fn recv(&mut self) -> Result<Self::DataFormat, ProtocolError<Self::CustomErr>> {
self.buffer.resize(1500, 0u8);
match self.half.read(&mut self.buffer).await {
if self.buffer.capacity() < 1500 {
self.buffer.reserve(1500 * 4); // reserve multiple, so that we alloc less often
}
match self.half.read_buf(&mut self.buffer).await {
Ok(0) => Err(ProtocolError::Custom(ProtocolsError::Tcp(io::Error::new(
io::ErrorKind::BrokenPipe,
"read returned 0 bytes",
)))),
Ok(n) => Ok(self.buffer.split_to(n)),
Ok(_) => Ok(self.buffer.split()),
Err(e) => Err(ProtocolError::Custom(ProtocolsError::Tcp(e))),
}
}