Address MR 1962 review comments.

This commit is contained in:
Avi Weinstock 2021-03-23 18:41:13 -04:00
parent 4ec6b43693
commit 6b343c2af9
2 changed files with 7 additions and 4 deletions

View File

@ -272,7 +272,7 @@ widget_ids! {
auto_walk_txt,
auto_walk_bg,
// Auto walk indicator
// Camera clamp indicator
camera_clamp_txt,
camera_clamp_bg,

View File

@ -274,9 +274,8 @@ impl PlayState for SessionState {
// Clamp camera's vertical angle if the toggle is enabled
if self.camera_clamp {
let mut cam_dir = camera.get_orientation();
let cam_dir_clamp = global_state.settings.gameplay.camera_clamp_angle as f32
* std::f32::consts::PI
/ 180.0;
let cam_dir_clamp =
(global_state.settings.gameplay.camera_clamp_angle as f32).to_radians();
cam_dir.y = (-cam_dir_clamp).max(cam_dir.y).min(cam_dir_clamp);
camera.set_orientation(cam_dir);
}
@ -1357,15 +1356,19 @@ impl PlayState for SessionState {
},
HudEvent::ChangeFreeLookBehavior(behavior) => {
global_state.settings.gameplay.free_look_behavior = behavior;
global_state.settings.save_to_file_warn();
},
HudEvent::ChangeAutoWalkBehavior(behavior) => {
global_state.settings.gameplay.auto_walk_behavior = behavior;
global_state.settings.save_to_file_warn();
},
HudEvent::ChangeCameraClampBehavior(behavior) => {
global_state.settings.gameplay.camera_clamp_behavior = behavior;
global_state.settings.save_to_file_warn();
},
HudEvent::ChangeStopAutoWalkOnInput(state) => {
global_state.settings.gameplay.stop_auto_walk_on_input = state;
global_state.settings.save_to_file_warn();
},
HudEvent::CraftRecipe(r) => {
self.client.borrow_mut().craft_recipe(&r);