Mirrored_Repos/veloren
1
0
Fork 0
mirror of https://gitlab.com/veloren/veloren.git synced 2024-08-30 18:12:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix spurious warning in KeyedJobs.

Browse Source
This commit is contained in:
Avi Weinstock 2021-07-05 13:09:42 -04:00
parent a8447fd62d
commit 86f5564dc7
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
voxygen/src/ui/keyed_jobs.rs
View File

@ -4,7 +4,6 @@ use std::{
hash::Hash, hash::Hash,
time::{Duration, Instant}, time::{Duration, Instant},
}; };
use tracing::warn;
enum KeyedJobTask<V> { enum KeyedJobTask<V> {
Pending(Instant, Option<SlowJob>), Pending(Instant, Option<SlowJob>),
@ -61,9 +60,11 @@ impl<K: Hash + Eq + Send + Sync + 'static + Clone, V: Send + Sync + 'static> Key
let fresh = now - *at < KEYEDJOBS_GC_INTERVAL; let fresh = now - *at < KEYEDJOBS_GC_INTERVAL;
if !fresh { if !fresh {
if let Some(job) = job.take() { if let Some(job) = job.take() {
if let Err(e) = pool.cancel(job) { // Cancelling a job only fails if the job doesn't exist anymore,
warn!(?e, "failed to cancel job"); // which means that it completed while we tried to GC its pending
} // struct, which means that we'll GC it in the next cycle, so ignore
// the error in this collection.
let _ = pool.cancel(job);
} }
} }
fresh fresh