Mirrored_Repos/veloren
1
0
Fork 0
mirror of https://gitlab.com/veloren/veloren.git synced 2024-08-30 18:12:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove site size from site suitability function.

Browse Source 
This was buggy, in that the requirement was for _any_ chunk
in the site area being suitable as opposed to _all_ chunks
in the site being suitable. This is easy to fix, but we don't
always want to have exactly the same criteria for the center
of a site as for the outskirts of it.

This should fix gnarling forts etc. spawning in the water just
off the shore.
This commit is contained in:
Tormod G. Hellen 2022-06-07 00:05:20 +02:00
parent 713828b8fe
commit c1335e16fe
1 changed files with 10 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
world/src/civ/mod.rs
View File

@ -116,19 +116,19 @@ impl Civs {
let mut castle_enemies: Vec<Vec2<i32>> = Vec::new();
for _ in 0..initial_civ_count * 3 {
attempt(5, || {
let (kind, size, avoid) = match ctx.rng.gen_range(0..64) {
0..=5 => (SiteKind::Castle, 3, (&castle_enemies, 40)),
let (kind, avoid) = match ctx.rng.gen_range(0..64) {
0..=5 => (SiteKind::Castle, (&castle_enemies, 40)),
28..=31 => {
if index.features().site2_giant_trees {
(SiteKind::GiantTree, 4, (&tree_enemies, 40))
(SiteKind::GiantTree, (&tree_enemies, 40))
} else {
(SiteKind::Tree, 4, (&tree_enemies, 40))
(SiteKind::Tree, (&tree_enemies, 40))
}
},
32..=37 => (SiteKind::Gnarling, 5, (&gnarling_enemies, 40)),
_ => (SiteKind::Dungeon, 0, (&dungeon_enemies, 40)),
32..=37 => (SiteKind::Gnarling, (&gnarling_enemies, 40)),
_ => (SiteKind::Dungeon, (&dungeon_enemies, 40)),
};
let loc = find_site_loc(&mut ctx, avoid, size, kind)?;
let loc = find_site_loc(&mut ctx, avoid, kind)?;
match kind {
SiteKind::Castle => {
gnarling_enemies.push(loc);
@ -552,7 +552,7 @@ impl Civs {
_ => SiteKind::Refactor,
};
let site = attempt(100, || {
let loc = find_site_loc(ctx, (start_locations, 60), 0, kind)?;
let loc = find_site_loc(ctx, (start_locations, 60), kind)?;
start_locations.push(loc);
Some(self.establish_site(ctx, loc, |place| Site {
kind,
@ -1144,7 +1144,6 @@ fn loc_suitable_for_site(sim: &WorldSim, loc: Vec2<i32>, site_kind: SiteKind) ->
fn find_site_loc(
ctx: &mut GenCtx<impl Rng>,
avoid: (&Vec<Vec2<i32>>, i32),
size: i32,
site_kind: SiteKind,
) -> Option<Vec2<i32>> {
const MAX_ATTEMPTS: usize = 10000;
@ -1165,10 +1164,8 @@ fn find_site_loc(
continue;
}
for offset in Spiral2d::new().take((size * 2 + 1).pow(2) as usize) {
if loc_suitable_for_site(ctx.sim, test_loc + offset, site_kind) {
return Some(test_loc);
}
if loc_suitable_for_site(ctx.sim, test_loc, site_kind) {
return Some(test_loc);
}
loc = ctx.sim.get(test_loc).and_then(|c| {