Marcel
0826707b0d
use --all-targets
which is the same as before AND --lib
.
...
Just to be future proof, lib should not matter ATM, but might in the future when we produce libs that are not used in any binary target
2021-01-14 08:16:25 +00:00
Marcel Märtens
68be467138
After some discussion with XVar, Song and Yakei we found out that cargo clippy
is a superset of cargo check
.
...
There are multiple hints:
- one guy in discord https://discord.gg/nWGhnbRb https://discord.com/channels/273534239310479360/335502067432947748/798886188923617290
- a old stackoverflow https://stackoverflow.com/questions/57449356/is-cargo-clippy-a-superset-of-cargo-check which lead us to the source code:
7fa1d78c89/src/main.rs (L73)
which either uses `check` or `fix`.
cargo fix is documented in the docs with (https://doc.rust-lang.org/cargo/commands/cargo-fix.html )
"executing cargo fix will under the hood execute cargo-check(1)."
- `cargo clippy` fails after running `cargo check` prob as there is nothing to do.
- `cargo clippy --help` points us to `cargo check --help`
Thus we are removing `cargo check` from the CI as a seperate check.
However `cargo check --examples` did check the examples.
In order to have them covered we are also running clippy now for examples, benches and all bins.
Also we moved `--locked` from cargo check to clippy.
2021-01-13 14:22:54 +01:00
Marcel Märtens
a3351be221
running cargo check
with -D warnings seems to trigger a complete cache invalidation.
...
AND cargo check was implicitly run in clippy. In order to be future save we now ALWAYS run all CI with -D warnings.
(i verified that this works in a test pipeline)
2021-01-12 01:15:13 +01:00
Marcel Märtens
8c883c200d
Switch veloren_network over to use the official example layout.
...
adjusted those examples to run again
created a CI TEST to always `check` examples
fixed fmt in examples so that pipeline gets green
2020-08-26 10:07:22 +02:00
Marcel Märtens
e1b27c51f5
fix clippy issues in tests and add it to CI
2020-07-01 00:37:15 +02:00
Marcel Märtens
b9344ffeb7
CI cleanup
...
- switching more to rules syntax
- clean up some templates
- EITHER optional builds or build builds
- ordering
2020-06-16 12:45:35 +02:00