juliancoffee
8f86f474e8
place asset_tweak behind a feature
2021-06-08 13:34:41 +03:00
Marcel Märtens
846df3a18a
--all-targets does not run targets that needs some features which are not provided. --all-features is NOT possible as we have some features which are conflicting.
...
The only possibility is to manually add the features we need to check in CI to the clippy query
2021-06-07 12:29:08 +02:00
Imbris
32ab0860ca
delete all incremental things for clippy CI
2021-06-01 14:15:01 -04:00
Imbris
1db0e2a15c
Use new multi image cache scheme in the CI and consolidate runner tag specification so that it is easier to modify
2021-06-01 13:19:12 -04:00
Marcel Märtens
c58eb1cf50
ci fails sporadically, remove file so it doesnt fail that often till we have a bettter toolchain
2021-03-23 10:30:29 +01:00
Marcel Märtens
3d195348d2
fix ci, which was broken by merging unittests and check
2021-01-23 23:05:24 +01:00
Ben Wallis
a590595149
Merged check and unit tests into single step
...
Reordered commands to run quickest first in order to tie up least CI resource
Fixed some clippy errors in examples
2021-01-19 19:58:51 +01:00
Marcel
0826707b0d
use --all-targets which is the same as before AND --lib.
...
Just to be future proof, lib should not matter ATM, but might in the future when we produce libs that are not used in any binary target
2021-01-14 08:16:25 +00:00
Marcel Märtens
68be467138
After some discussion with XVar, Song and Yakei we found out that cargo clippy is a superset of cargo check.
...
There are multiple hints:
- one guy in discord https://discord.gg/nWGhnbRb https://discord.com/channels/273534239310479360/335502067432947748/798886188923617290
- a old stackoverflow https://stackoverflow.com/questions/57449356/is-cargo-clippy-a-superset-of-cargo-check which lead us to the source code:
7fa1d78c89/src/main.rs (L73)https://doc.rust-lang.org/cargo/commands/cargo-fix.html )
"executing cargo fix will under the hood execute cargo-check(1)."
- `cargo clippy` fails after running `cargo check` prob as there is nothing to do.
- `cargo clippy --help` points us to `cargo check --help`
Thus we are removing `cargo check` from the CI as a seperate check.
However `cargo check --examples` did check the examples.
In order to have them covered we are also running clippy now for examples, benches and all bins.
Also we moved `--locked` from cargo check to clippy.
2021-01-13 14:22:54 +01:00
Marcel Märtens
a3351be221
running cargo check with -D warnings seems to trigger a complete cache invalidation.
...
AND cargo check was implicitly run in clippy. In order to be future save we now ALWAYS run all CI with -D warnings.
(i verified that this works in a test pipeline)
2021-01-12 01:15:13 +01:00
Marcel Märtens
8c883c200d
Switch veloren_network over to use the official example layout.
...
adjusted those examples to run again
created a CI TEST to always `check` examples
fixed fmt in examples so that pipeline gets green
2020-08-26 10:07:22 +02:00
Marcel Märtens
e1b27c51f5
fix clippy issues in tests and add it to CI
2020-07-01 00:37:15 +02:00
Marcel Märtens
b9344ffeb7
CI cleanup
...
- switching more to rules syntax
- clean up some templates
- EITHER optional builds or build builds
- ordering
2020-06-16 12:45:35 +02:00
