Merge branch 'tygyh/Resolve-all-'#allow(clippy--unused_unit)]'-error-supressions' into 'master'

Resolve all '#[allow(clippy::unused_unit)]' error supressions

See merge request veloren/veloren!2600

voxygen/src/hud/bag.rs

@@ -566,8 +566,7 @@ impl<'a> Widget for Bag<'a> {
         }
     }
 
-    #[allow(clippy::unused_unit)] // TODO: Pending review in #587
-    fn style(&self) -> Self::Style { () }
+    fn style(&self) -> Self::Style {}
 
     #[allow(clippy::useless_format)] // TODO: Pending review in #587
     fn update(self, args: widget::UpdateArgs<Self>) -> Self::Event {

voxygen/src/hud/buttons.rs

@@ -120,8 +120,7 @@ impl<'a> Widget for Buttons<'a> {
         }
     }
 
-    #[allow(clippy::unused_unit)] // TODO: Pending review in #587
-    fn style(&self) -> Self::Style { () }
+    fn style(&self) -> Self::Style {}
 
     fn update(self, args: widget::UpdateArgs<Self>) -> Self::Event {
         common_base::prof_span!("Buttons::update");

voxygen/src/hud/chat.rs

@@ -200,8 +200,7 @@ impl<'a> Widget for Chat<'a> {
         }
     }
 
-    #[allow(clippy::unused_unit)] // TODO: Pending review in #587
-    fn style(&self) -> Self::Style { () }
+    fn style(&self) -> Self::Style {}
 
     #[allow(clippy::redundant_clone)] // TODO: Pending review in #587
     #[allow(clippy::single_match)] // TODO: Pending review in #587

voxygen/src/hud/crafting.rs

@@ -230,8 +230,7 @@ impl<'a> Widget for Crafting<'a> {
         }
     }
 
-    #[allow(clippy::unused_unit)] // TODO: Pending review in #587
-    fn style(&self) -> Self::Style { () }
+    fn style(&self) -> Self::Style {}
 
     fn update(self, args: widget::UpdateArgs<Self>) -> Self::Event {
         common_base::prof_span!("Crafting::update");

voxygen/src/hud/diary.rs

@@ -256,8 +256,7 @@ impl<'a> Widget for Diary<'a> {
 
     fn init_state(&self, id_gen: widget::id::Generator) -> Self::State { Ids::new(id_gen) }
 
-    #[allow(clippy::unused_unit)] // TODO: Pending review in #587
-    fn style(&self) -> Self::Style { () }
+    fn style(&self) -> Self::Style {}
 
     fn update(mut self, args: widget::UpdateArgs<Self>) -> Self::Event {
         common_base::prof_span!("Diary::update");

voxygen/src/hud/esc_menu.rs

@@ -63,8 +63,7 @@ impl<'a> Widget for EscMenu<'a> {
         }
     }
 
-    #[allow(clippy::unused_unit)] // TODO: Pending review in #587
-    fn style(&self) -> Self::Style { () }
+    fn style(&self) -> Self::Style {}
 
     fn update(self, args: widget::UpdateArgs<Self>) -> Self::Event {
         common_base::prof_span!("EscMenu::update");

voxygen/src/hud/group.rs

@@ -145,7 +145,6 @@ impl<'a> Widget for Group<'a> {
     //TODO: Disband groups when there's only one member in them
     //TODO: Always send health, energy, level and position of group members to the
     // client
-    #[allow(clippy::unused_unit)] // TODO: Pending review in #587
     #[allow(clippy::blocks_in_if_conditions)] // TODO: Pending review in #587
     fn update(self, args: widget::UpdateArgs<Self>) -> Self::Event {
         common_base::prof_span!("Group::update");

voxygen/src/hud/loot_scroller.rs

@@ -126,8 +126,7 @@ impl<'a> Widget for LootScroller<'a> {
         }
     }
 
-    #[allow(clippy::unused_unit)] // TODO: Pending review in #587
-    fn style(&self) -> Self::Style { () }
+    fn style(&self) -> Self::Style {}
 
     fn update(self, args: widget::UpdateArgs<Self>) -> Self::Event {
         let widget::UpdateArgs { state, ui, .. } = args;

voxygen/src/hud/map.rs

@@ -192,8 +192,7 @@ impl<'a> Widget for Map<'a> {
         }
     }
 
-    #[allow(clippy::unused_unit)] // TODO: Pending review in #587
-    fn style(&self) -> Self::Style { () }
+    fn style(&self) -> Self::Style {}
 
     #[allow(clippy::useless_format)] // TODO: Pending review in #587
     fn update(self, args: widget::UpdateArgs<Self>) -> Self::Event {

voxygen/src/hud/minimap.rs

@@ -433,8 +433,7 @@ impl<'a> Widget for MiniMap<'a> {
         }
     }
 
-    #[allow(clippy::unused_unit)] // TODO: Pending review in #587
-    fn style(&self) -> Self::Style { () }
+    fn style(&self) -> Self::Style {}
 
     fn update(self, args: widget::UpdateArgs<Self>) -> Self::Event {
         common_base::prof_span!("Minimap::update");

voxygen/src/hud/popup.rs

@@ -80,8 +80,7 @@ impl<'a> Widget for Popup<'a> {
         }
     }
 
-    #[allow(clippy::unused_unit)] // TODO: Pending review in #587
-    fn style(&self) -> Self::Style { () }
+    fn style(&self) -> Self::Style {}
 
     #[allow(clippy::single_match)] // TODO: Pending review in #587
     fn update(self, args: widget::UpdateArgs<Self>) -> Self::Event {

voxygen/src/hud/prompt_dialog.rs

@@ -79,8 +79,7 @@ impl<'a> Widget for PromptDialog<'a> {
         }
     }
 
-    #[allow(clippy::unused_unit)] // TODO: Pending review in #587
-    fn style(&self) -> Self::Style { () }
+    fn style(&self) -> Self::Style {}
 
     fn update(self, args: widget::UpdateArgs<Self>) -> Self::Event {
         common_base::prof_span!("PromptDialog::update");

voxygen/src/hud/settings_window/chat.rs

@@ -118,8 +118,7 @@ impl<'a> Widget for Chat<'a> {
         }
     }
 
-    #[allow(clippy::unused_unit)] // TODO: Pending review in #587
-    fn style(&self) -> Self::Style { () }
+    fn style(&self) -> Self::Style {}
 
     fn update(self, args: widget::UpdateArgs<Self>) -> Self::Event {
         common_base::prof_span!("Chat::update");

voxygen/src/hud/settings_window/controls.rs

@@ -68,8 +68,7 @@ impl<'a> Widget for Controls<'a> {
         }
     }
 
-    #[allow(clippy::unused_unit)] // TODO: Pending review in #587
-    fn style(&self) -> Self::Style { () }
+    fn style(&self) -> Self::Style {}
 
     fn update(self, args: widget::UpdateArgs<Self>) -> Self::Event {
         common_base::prof_span!("Controls::update");

voxygen/src/hud/settings_window/gameplay.rs

@@ -94,8 +94,7 @@ impl<'a> Widget for Gameplay<'a> {
         }
     }
 
-    #[allow(clippy::unused_unit)] // TODO: Pending review in #587
-    fn style(&self) -> Self::Style { () }
+    fn style(&self) -> Self::Style {}
 
     fn update(self, args: widget::UpdateArgs<Self>) -> Self::Event {
         common_base::prof_span!("Gameplay::update");

voxygen/src/hud/settings_window/interface.rs

@@ -135,8 +135,7 @@ impl<'a> Widget for Interface<'a> {
         }
     }
 
-    #[allow(clippy::unused_unit)] // TODO: Pending review in #587
-    fn style(&self) -> Self::Style { () }
+    fn style(&self) -> Self::Style {}
 
     fn update(self, args: widget::UpdateArgs<Self>) -> Self::Event {
         common_base::prof_span!("Interface::update");

voxygen/src/hud/settings_window/language.rs

@@ -63,8 +63,7 @@ impl<'a> Widget for Language<'a> {
         }
     }
 
-    #[allow(clippy::unused_unit)] // TODO: Pending review in #587
-    fn style(&self) -> Self::Style { () }
+    fn style(&self) -> Self::Style {}
 
     fn update(self, args: widget::UpdateArgs<Self>) -> Self::Event {
         common_base::prof_span!("Language::update");

voxygen/src/hud/settings_window/mod.rs

@@ -144,8 +144,7 @@ impl<'a> Widget for SettingsWindow<'a> {
         }
     }
 
-    #[allow(clippy::unused_unit)] // TODO: Pending review in #587
-    fn style(&self) -> Self::Style { () }
+    fn style(&self) -> Self::Style {}
 
     fn update(self, args: widget::UpdateArgs<Self>) -> Self::Event {
         common_base::prof_span!("SettingsWindow::update");

voxygen/src/hud/settings_window/sound.rs

@@ -76,8 +76,7 @@ impl<'a> Widget for Sound<'a> {
         }
     }
 
-    #[allow(clippy::unused_unit)] // TODO: Pending review in #587
-    fn style(&self) -> Self::Style { () }
+    fn style(&self) -> Self::Style {}
 
     fn update(self, args: widget::UpdateArgs<Self>) -> Self::Event {
         common_base::prof_span!("Sound::update");

voxygen/src/hud/settings_window/video.rs

@@ -173,8 +173,7 @@ impl<'a> Widget for Video<'a> {
         }
     }
 
-    #[allow(clippy::unused_unit)] // TODO: Pending review in #587
-    fn style(&self) -> Self::Style { () }
+    fn style(&self) -> Self::Style {}
 
     fn update(self, args: widget::UpdateArgs<Self>) -> Self::Event {
         common_base::prof_span!("Video::update");

voxygen/src/hud/skillbar.rs

@@ -222,8 +222,7 @@ impl<'a> Widget for Skillbar<'a> {
         }
     }
 
-    #[allow(clippy::unused_unit)] // TODO: Pending review in #587
-    fn style(&self) -> Self::Style { () }
+    fn style(&self) -> Self::Style {}
 
     fn update(self, args: widget::UpdateArgs<Self>) -> Self::Event {
         common_base::prof_span!("Skillbar::update");

voxygen/src/hud/social.rs

@@ -105,8 +105,7 @@ impl<'a> Widget for Social<'a> {
         }
     }
 
-    #[allow(clippy::unused_unit)] // TODO: Pending review in #587
-    fn style(&self) -> Self::Style { () }
+    fn style(&self) -> Self::Style {}
 
     fn update(self, args: widget::UpdateArgs<Self>) -> Self::Event {
         common_base::prof_span!("Social::update");

voxygen/src/ui/widgets/image_frame.rs

@@ -133,8 +133,7 @@ impl Widget for ImageFrame {
         }
     }
 
-    #[allow(clippy::unused_unit)] // TODO: Pending review in #587
-    fn style(&self) -> Self::Style { () }
+    fn style(&self) -> Self::Style {}
 
     /// Update the state of the ImageFrame
     fn update(self, args: widget::UpdateArgs<Self>) -> Self::Event {

voxygen/src/ui/widgets/image_slider.rs

@@ -175,8 +175,7 @@ where
         }
     }
 
-    #[allow(clippy::unused_unit)] // TODO: Pending review in #587
-    fn style(&self) -> Self::Style { () }
+    fn style(&self) -> Self::Style {}
 
     /// Update the state of the Slider.
     fn update(self, args: widget::UpdateArgs<Self>) -> Self::Event {

voxygen/src/ui/widgets/ingame.rs

@@ -87,8 +87,7 @@ impl<W: Ingameable> Widget for Ingame<W> {
         }
     }
 
-    #[allow(clippy::unused_unit)] // TODO: Pending review in #587
-    fn style(&self) -> Self::Style { () }
+    fn style(&self) -> Self::Style {}
 
     fn update(self, args: widget::UpdateArgs<Self>) -> Self::Event {
         let widget::UpdateArgs { state, ui, .. } = args;

voxygen/src/ui/widgets/outlined_text.rs

@@ -66,8 +66,7 @@ impl<'a> Widget for OutlinedText<'a> {
         }
     }
 
-    #[allow(clippy::unused_unit)] // TODO: Pending review in #587
-    fn style(&self) -> Self::Style { () }
+    fn style(&self) -> Self::Style {}
 
     fn update(self, args: widget::UpdateArgs<Self>) -> Self::Event {
         let widget::UpdateArgs {

voxygen/src/ui/widgets/radio_list.rs

@@ -113,8 +113,7 @@ impl<'a, T> Widget for RadioList<'a, T> {
         }
     }
 
-    #[allow(clippy::unused_unit)] // TODO: Pending review in #587
-    fn style(&self) -> Self::Style { () }
+    fn style(&self) -> Self::Style {}
 
     #[allow(clippy::needless_range_loop)] // TODO: Pending review in #587
     fn update(self, args: widget::UpdateArgs<Self>) -> Self::Event {

voxygen/src/ui/widgets/slot.rs

@@ -568,8 +568,7 @@ where
         }
     }
 
-    #[allow(clippy::unused_unit)] // TODO: Pending review in #587
-    fn style(&self) -> Self::Style { () }
+    fn style(&self) -> Self::Style {}
 
     /// Update the state of the Slot.
     fn update(self, args: widget::UpdateArgs<Self>) -> Self::Event {

voxygen/src/ui/widgets/toggle_button.rs

@@ -87,8 +87,7 @@ impl Widget for ToggleButton {
         }
     }
 
-    #[allow(clippy::unused_unit)] // TODO: Pending review in #587
-    fn style(&self) -> Self::Style { () }
+    fn style(&self) -> Self::Style {}
 
     fn update(self, args: widget::UpdateArgs<Self>) -> Self::Event {
         let widget::UpdateArgs {