Commit Graph

15 Commits

Author SHA1 Message Date
Tuupertunut
0644ad9ca2 Rearm bugfixing (#5411)
* Added workaround functions for turret magazine ammo.

* Switched to retrieving turrets dynamically instead of looking them up from an array.

* Refactoring only, no functional changes

* Repurposed getNeedRearmMagazines as a general purpose rearm info function + more.

* The function retrieves all non-full magazines. This code was previously repeated in many different functions, but is now centralized in one.
* Empty pylon filling is no longer supported in favor of the upcoming "pylons" ACE-module.

Fixed bugs:

* Rearm was using broken commands "magazineTurretAmmo" and "setMagazineTurretAmmo". They are now replaced with their corresponding workaround functions.
* Pylon rearm was trying to set ammo count on empty pylons.

Note: rearmSuccessLocal is not yet fixed!

* Rearming no longer switches shell types in cannons/mortars.

* Added Tuupertunut to authors.

* Rearming no longer switches shell types. 2nd try.

Last time it was fixed only if the turret is manned. Now it is fixed even when unmanned.

* Updated fnc_rearm to support the earlier repurposing of fnc_getNeedRearmMagazines.

* Small fixes and comments.

* Renamed fnc_getVehicleMagazines to fnc_getTurretConfigMagazines.

The latter describes much better what the function actually does.

* Removed redundant checks.

* Refactoring.

* Fixed spaces in macros.

* Renamed fnc_getAllTurrets to fnc_getAllRearmTurrets
2017-09-29 14:53:25 -05:00
PabstMirror
c28628aed2 Fix rearm turret events (#5307) 2017-07-10 17:17:44 +02:00
PabstMirror
b192be0b70 Fix merge, cbaEvents, macros, cleanup 2017-05-18 12:42:02 -05:00
GitHawk
d0509830e3 Some things
Made params nicer, replaced some forEach and used params in XEH_respawn
2016-05-12 14:55:40 +02:00
GitHawk
29cd940fd0 Added server events 2016-03-07 07:15:01 +01:00
Githawk
8dc99a4a4e Replacing execRemoteFnc with events 2016-03-06 11:14:34 +01:00
Githawk
3d7c51bdf1 Cleanup 2016-02-27 21:05:19 +01:00
Githawk
91c6341bc8 Implementation 2016-02-27 20:31:07 +01:00
Githawk
cc624f58dd Fixes and updates 2016-02-01 20:05:53 +01:00
IngoKauffmann
bdc5e54f55 Fixed turret locality and driver empty magazine issues 2015-08-19 17:33:32 +02:00
IngoKauffmann
cf9c49f13c Attempt to fix turret locality issues 2015-08-18 18:09:37 +02:00
IngoKauffmann
3072bd9d22 Fixed rearm sucess hint and collision with dummy 2015-08-18 17:38:50 +02:00
jonpas
33e92f8ca0 Fixed SmokeLauncherMag rearming on level 0 when empty 2015-08-18 02:57:39 +02:00
jonpas
c8c6488125 Cleaned, improved, fixed, changed - entire rearm 2015-08-18 02:32:10 +02:00
IngoKauffmann
3eaaca84fb Added different rearm levels 2015-08-16 02:18:53 +02:00