* Optimise spectator loops
`count` is only quicker than `forEach` when the final command returns a
boolean or nil. `forEach` is quicker if the final command returns any
other data type.
* Use `forEach` instead of `count`
* Remove deprecated functionality for 3.12.0
* Remove associated deprecated module icon
* Restore a dummy version of old module
This is just to prevent existing missions from breaking due to a missing
object.
This is a weird engine behaviour where draw3D doesn't work if the
current camera unit is not alive (or going to respawn), so we switch to
a temporary agent unit while in free camera to work around this edge
case.
* Add player initilization safety to setSpectator
Public function which should wait for player unit to exist before running.
With this change an additional variable is now set on the player unit which
can be used to check whether players are spectators or not (part of
grander plans).
* Add UI initalization safety to setSpectator
Should make it so that calling the public function before the main display
has initalized will correctly wait until it has before starting spectator
* Overhaul spectator
Initial WIP overhaul of spectator component. Based on BI's End Game
Spectator and AACO's work on POTATO spectate. The essential functionality
is in place, but some things are broken and some are still to be
transferred.
* Remove redundant canInteract condition
Spectator UI will be open anyway so this is pointless.
* Fix follow camera controls
Also ensure unit camera modes have a target more consistently
* Fix widget weapon icon for unarmed
* Fix follow camera zooming
* Fix entity list not updating correctly
* Remove redundant conditions
* Fix list click behaviour
* Remove a bunch of old debug
* Alter behaviour of camera speed
* Restructure the spectator addon
* Fix camera tracking behaviour
* Fix very fast camera toggle
* Fix initial camera mode
* Fix double click behaviour
* Make AI name display consistent
* Add UI toggle
* Fix current camera mode button highlighting
* Fix focus info widget when clicked on in 3D world
* Improve key handling
Use of `inputAction` could result in weirdness when multiple keys pressed
at the same time. Hardcoded for now.
* Implement dynamic help UI element
* Remove some redundant code
* Fix follow camera jitter
* Add projectile drawing
Technically the capability to draw projectiles has been in since the
start. However it took me a bit of time to figure out how best to
add/remove the required event handlers.
I decided to add them during the process of finding things to draw, since
I'm iterating over the list of spectatable entities here anyway. With an
additional GVAR containing up to date entities, the fired EHs can remove
themselves when applicable. This avoids any granularity issues with adding
EHs en masse.
* Improve naming convention related to drawing
* Remove outdated unit and side settings
Also re-add unit whitelisting/blacklisting support
* Rename public function for consistency
Adds a deprecated warning to the old function name.
* Update stringtable
Some entries are replaced with BI translations, others are no longer
needed. I pieced together one of the camera mode settings by combining the
BI translations of the individual versions.
* Add location public functions and list population
Just need to take care of drawing and then camera interaction now
* Add location 2D and 3D drawing
* Respect whitelist and blacklist correctly
* Add location camera focus capability
* Fix local helicopters follow mode bug
* Add compatibility with `counter` template
Simply repositions the counter UI to the top of the screen out of the way
* Update respawn template
This template is only compatible with respawn types 2 & 3
* Rename compatibility function
* Add compatibility for respawn types 1,4 and 5
* Update setCameraAttributes function
* Fix draw3D for respawn types 1,4 and 5
* Fix screeching seagulls #4265
* Fix script command typo
* SQF Linter Pass
* Add obsolete warning for public func params
* Deprecate interrupt function
* Fix incorrect function call
* Make playable virtual spectator work
* Improve focus handling in public function
- User might want to reset focus for free cam, in which case objNull
cannot be reserved for random
- Focus is still required for unit camera
- Update some function headers
* Note explicitly the use of `player`
* Remove unused base classes
* Improve seagull culling
* Add projectile drawing to vehicles
* Fix same tab selection clearing list
* Make projectile lines last 1 frame longer
* Add true zeus compatibility
- Re-opens spectator when zeus closes
- Transfers the curator module over in the respawn template
- Only handle uiForced in setSpectator to avoid issues with esc key
- Add safety to setFocus so that it only updates the UI when applicable
* Fix player moving in FPP
* Fix zeus transfer and re-opening
* Consolidate icon definitions
* Fix AI setting for player groups
* Improve handling of alive spectators
Instead of disabling simulation, just stage them automatically if alive.
* Fix respawn template for types 2 & 3
* Fix pre-set camera mode with no focus
- Improve handling of UI updates in camera related functions
- More explicit UI initalisation
- Find a focus if one wasn't pre-set for a camera mode which requires a
focus
* Localise key names
* Fix camera mode and vision settings on init
When spectator starts the available camera modes and vision modes should
be consulted to ensure they are respected upon opening.
* Fix key localisation
* Add next/prev entity keys
* Fix vision modes update while camera active
- Updates the camera vision mode in case the current was removed
* Add public getCameraAttributes function
* Fix spectator zeus compatibility
- Camera control wasn't returned on exit due to change in fnc_ui
* Improve vision mode handling
- Curator now resets vision mode on entry
- First person also reset vision mode so that it is consistent between
camera changes
* Improve location handling
- It makes more sense to specifiy the position ATL since the text is going
to be rendered there and a z of 0 is then ground height.
- Updates the ui immediately if the list is already on locations
* Disable list keyboard search
* Fix handling of forced camera mode with no focus
* Fix handling of free mode removal while no target
* Fix locations respecting available modes
* Fix list entry removal code
- Replace getTargetGroups with getTargetEntities for consolidated
filtering.
- Fix the step of the removal loops and make them go to index 0 instead of
1
* Improve side handling of unit list
- Accounts for possibly of whitelisted random objects that belong to other
sides
- Move the index decrement to loop, not within every loop
* Add linter ignore directive
* Fix list code
* Improve entity fetching
- Change whitelist/blacklist application to optimize the code
* Include dead units in the list
- Allow getTargetEntities to return dead units too
- Iterate over allGroups in list updates to reduce overhead
* Take care of TODOs
* Mark stageSpectator as non-public
* Fix updating list focus
* Adjust default camera speed
* Include the function file
* Generalise camera button UI
- Makes it easier to extend with future camera mode buttons
- Removes potential error when display doesn't exist
* Remove obsolete staged event
- Add vision toggle to help
- Restructure some function PREP
* Add public function to return all spectators
* Change default briefing name used on map display
* Fix the order of 4 main sides in list
* Restore non-toggle behaviour of camera speed
* Fix UI gap between list and tabs
* Force update UI list when player is staged
Hopefully this fixes any issues related to the player appearing in the
list
* Update controls strings
* Fix entity tooltips showing short name
- Also revert changes to common function and just handle in this component
* Include dead in unit switching
* Show rank and vehicle icon in list
- Rank is shown in tooltip
- Vehicle icon is used to see which units in the list are mounted
* Change default vehicle icon
* Show whether medic/engineer in tooltip
* Improve list double click behaviour
* Improve group icon handling
* Use dynamic group icons for drawing
* Fix EFUNC call
* Update all function headers
* All the changes I had staged before arma broke git
Arma managed to crash my whole system again, breaking my git repo and I
resorted to nuking it and pasting the changes I had comitted locally back
in. From memory:
- Fix icon paths
- use distanceSqr for minor speed boost
- Add setting to show map locations in the UI
- Limit location rendering based on distance
- Probably some other crap
* Fix squared comparisons
* Remove unnecessary variable publicity
* Deprecate fnc_stageSpectator
The function was a source of confusion alongside fnc_setSpectator and so
it is replaced by an additional parameter to hide the unit as part of
fnc_setSpectator. No longer is the unit moved either, to reduce complexity
and give more control to mission maker.
* Fix undefined variable
* Update spectator framework doc
* Update spectator feature doc
* Fix typos and grammar
* Revent version introduced number
* Update with new changes
* Everything
* Fixed missing ;
* Fix missing ; and double private
* Fixed cannot isNull on number
* Turn _temparture back to isNil
* Fix error from merge
* Optimise cursor object updates
* Restrict distance units can be selected from
* Fix potential for no icons to render in FPP
* Limit projectile drawing distance
* Optimise icon updates
* Fix group names not being drawn in vehicles
* Fix selection nameplate not drawing for vehicles
* Fix selection of non-spectatable entities
* Fix incorrect function input for spectator hiding
* Remove locations tab from spectator
- Doesn't add much value, adds complexity and the implementation is half
baked. Would rather add back in at a later date (if at all) with a
better implementation.
- I have an idea to replace the locations tab with a meta tab so users
can toggle things like projectile drawing via the UI and are not forced
to use a hotkey. Might also be a good place to display the extended controls.
- Overhauls the spectator module entirely to share a similar UX to BI's "End Game Spectator" while maintaining some of the extended flexibility of ACE Spectator.
- Simplifies spectator setup by reducing the number of settings. More advanced setup is still possible via the API functions provided.
The default values of the arrays manipulated by these functions overwrite
any changes applied before settings have finished initalising. This won't
be an issue after #4456 is merged in future.
* Optimizations with private, params, and isEqualType
* Fixed tab being used instead of space
* Fixed tabs inserted by notepad++
* More usage of new private syntax and params
- changed a few checks for an array being empty to `_arr isEqualTo []`
rather than `count _arr == 0`
- added more uses of `private` on the same line as the variable is
declared
- added more uses of params to assign variables passed as parameters
- removed unnecessary parentheses
- removed several unnecessary variable declarations with private array
syntax
* clean up and formatting
Reduce the time between automated refreshing of the unit tree. Also makes an initial call to the tree populating code upon first opening to remove the initial delay.
- Account for decrement in node index when culling the tree of sides/groups/units
- Fix non-zero-based index `to` value when navigating the units in the tree
